migrate all test_aten_ops to facto #13483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13483
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit 1bafbd8 with merge base 335de46 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79121474 |
This PR needs a
|
zonglinpeng
force-pushed
the
export-D79121474
branch
from
dd89d28 to
d67514e
Compare
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Aug 18, 2025
Summary: **Have to ship this as an intermediate step to unblock 3 workstreams on the stack** Modify aten tests to ingress FACTO generated testcases. - Each test gets 30~50 cases with good coverage on - Optimized VS unoptimized flows - dtype switch cases Known issues: - FACTO test class is too big to run on default "heavyweight" CI - current skipping the whole target on CI. Will add back once skycastle flow is ready - some FACTO is creating inputs that kernels does not handle, mainly dtypes - will create exception handling for that. - TODO marks the 2 FACTO doesnt work well on the 2 ops. Differential Revision: D79121474
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79121474 |
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Aug 19, 2025
Summary: **Have to ship this as an intermediate step to unblock 3 workstreams on the stack** Modify aten tests to ingress FACTO generated testcases. - Each test gets 30~50 cases with good coverage on - Optimized VS unoptimized flows - dtype switch cases Known issues: - FACTO test class is too big to run on default "heavyweight" CI - current skipping the whole target on CI. Will add back once skycastle flow is ready - some FACTO is creating inputs that kernels does not handle, mainly dtypes - will create exception handling for that. - TODO marks the 2 FACTO doesnt work well on the 2 ops. Differential Revision: D79121474
zonglinpeng
force-pushed
the
export-D79121474
branch
from
d67514e to
e176c91
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79121474 |
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Aug 19, 2025
Summary: Pull Request resolved: pytorch#13483 **Have to ship this as an intermediate step to unblock 3 workstreams on the stack** Modify aten tests to ingress FACTO generated testcases. - Each test gets 30~50 cases with good coverage on - Optimized VS unoptimized flows - dtype switch cases Known issues: - FACTO test class is too big to run on default "heavyweight" CI - current skipping the whole target on CI. Will add back once skycastle flow is ready - some FACTO is creating inputs that kernels does not handle, mainly dtypes - will create exception handling for that. - TODO marks the 2 FACTO doesnt work well on the 2 ops. Differential Revision: D79121474
zonglinpeng
force-pushed
the
export-D79121474
branch
from
e176c91 to
d511079
Compare
manuelcandales
approved these changes
Aug 19, 2025
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Aug 19, 2025
Summary: **Have to ship this as an intermediate step to unblock 3 workstreams on the stack** Modify aten tests to ingress FACTO generated testcases. - Each test gets 30~50 cases with good coverage on - Optimized VS unoptimized flows - dtype switch cases Known issues: - FACTO test class is too big to run on default "heavyweight" CI - current skipping the whole target on CI. Will add back once skycastle flow is ready - some FACTO is creating inputs that kernels does not handle, mainly dtypes - will create exception handling for that. - TODO marks the 2 FACTO doesnt work well on the 2 ops. Reviewed By: manuelcandales Differential Revision: D79121474
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Aug 19, 2025
Summary: **Have to ship this as an intermediate step to unblock 3 workstreams on the stack** Modify aten tests to ingress FACTO generated testcases. - Each test gets 30~50 cases with good coverage on - Optimized VS unoptimized flows - dtype switch cases Known issues: - FACTO test class is too big to run on default "heavyweight" CI - current skipping the whole target on CI. Will add back once skycastle flow is ready - some FACTO is creating inputs that kernels does not handle, mainly dtypes - will create exception handling for that. - TODO marks the 2 FACTO doesnt work well on the 2 ops. Reviewed By: manuelcandales, hsharma35 Differential Revision: D79121474
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Aug 20, 2025
Summary: **Have to ship this as an intermediate step to unblock 3 workstreams on the stack** Modify aten tests to ingress FACTO generated testcases. - Each test gets 30~50 cases with good coverage on - Optimized VS unoptimized flows - dtype switch cases Known issues: - FACTO test class is too big to run on default "heavyweight" CI - current skipping the whole target on CI. Will add back once skycastle flow is ready - some FACTO is creating inputs that kernels does not handle, mainly dtypes - will create exception handling for that. - TODO marks the 2 FACTO doesnt work well on the 2 ops. Reviewed By: manuelcandales, hsharma35 Differential Revision: D79121474
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Aug 20, 2025
Summary: **Have to ship this as an intermediate step to unblock 3 workstreams on the stack** Modify aten tests to ingress FACTO generated testcases. - Each test gets 30~50 cases with good coverage on - Optimized VS unoptimized flows - dtype switch cases Known issues: - FACTO test class is too big to run on default "heavyweight" CI - current skipping the whole target on CI. Will add back once skycastle flow is ready - some FACTO is creating inputs that kernels does not handle, mainly dtypes - will create exception handling for that. - TODO marks the 2 FACTO doesnt work well on the 2 ops. Reviewed By: manuelcandales, hsharma35 Differential Revision: D79121474
Summary: **Have to ship this as an intermediate step to unblock 3 workstreams on the stack** Modify aten tests to ingress FACTO generated testcases. - Each test gets 30~50 cases with good coverage on - Optimized VS unoptimized flows - dtype switch cases Known issues: - FACTO test class is too big to run on default "heavyweight" CI - current skipping the whole target on CI. Will add back once skycastle flow is ready - some FACTO is creating inputs that kernels does not handle, mainly dtypes - will create exception handling for that. - TODO marks the 2 FACTO doesnt work well on the 2 ops. Reviewed By: manuelcandales, hsharma35 Differential Revision: D79121474
zonglinpeng
force-pushed
the
export-D79121474
branch
from
d511079 to
1bafbd8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79121474 |
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Aug 21, 2025
Summary: **Have to ship this as an intermediate step to unblock 3 workstreams on the stack** Modify aten tests to ingress FACTO generated testcases. - Each test gets 30~50 cases with good coverage on - Optimized VS unoptimized flows - dtype switch cases Known issues: - FACTO test class is too big to run on default "heavyweight" CI - current skipping the whole target on CI. Will add back once skycastle flow is ready - some FACTO is creating inputs that kernels does not handle, mainly dtypes - will create exception handling for that. - TODO marks the 2 FACTO doesnt work well on the 2 ops. Reviewed By: manuelcandales, hsharma35 Differential Revision: D79121474
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
Differential Revision: D79121474 Pull Request resolved: pytorch#13483
kimishpatel
pushed a commit
that referenced
this pull request
Sep 2, 2025
Differential Revision: D79121474 Pull Request resolved: #13483
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Have to ship this as an intermediate step to unblock 3 workstreams on the stack
Modify aten tests to ingress FACTO generated testcases.
Known issues:
Differential Revision: D79121474