Skip to content

Conversation

@roman-janik-nxp
Copy link
Collaborator

@roman-janik-nxp roman-janik-nxp commented Aug 18, 2025

Summary

Introduces ModelInputSpec for specification of model inputs. Arbitrary data type of model input can now be specified. Moves creation of calibration data outside main to_quantized_edge_program() function, thus enables using different data source than random data creation.

Test plan

All tests that use executorch_pipeline.py calls - almost all of backend tests.

cc @digantdesai @JakeStevens @robert-kalmar

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13494

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 6 New Failures, 1 Unrelated Failure

As of commit eec0b4d with merge base 473df33 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 18, 2025
@roman-janik-nxp
Copy link
Collaborator Author

@pytorchbot label "module: nxp" "release notes: nxp"

@pytorch-bot pytorch-bot bot added module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate labels Aug 18, 2025
@roman-janik-nxp roman-janik-nxp force-pushed the upstream/main-nxp/EIEX-403-upstream-relocation-of-calibration-inputs-creation branch 2 times, most recently from 5055796 to e06ffc2 Compare August 22, 2025 14:53
Copy link
Collaborator

@MartinPavella MartinPavella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test 3

@robert-kalmar
Copy link
Collaborator

@roman-janik-nxp Please rebase and resolve conflicts.

…ge_program()

Enables using different sources for data source
@roman-janik-nxp roman-janik-nxp force-pushed the upstream/main-nxp/EIEX-403-upstream-relocation-of-calibration-inputs-creation branch from e06ffc2 to eec0b4d Compare August 29, 2025 12:56
@robert-kalmar robert-kalmar merged commit deaf37f into pytorch:main Sep 1, 2025
105 of 112 checks passed
@robert-kalmar robert-kalmar deleted the upstream/main-nxp/EIEX-403-upstream-relocation-of-calibration-inputs-creation branch September 1, 2025 08:09
@shoumikhin
Copy link
Contributor

@roman-janik-nxp please check the following Pyre typechecks are resolved:

    [executorch/backends/nxp/tests/executorch_pipeline.py:68:8] Incompatible return type [7]: Expected `typing.Tuple[ModelInputSpec, ...]` but got `Union[typing.Tuple[ModelInputSpec, ...], typing.Tuple[int, ...]]`.
    [executorch/backends/nxp/tests/executorch_pipeline.py:73:31] Incompatible parameter type [6]: In call `ModelInputSpec.__init__`, for 1st positional argument, expected `typing.Tuple[int, ...]` but got `typing.Tuple[Union[ModelInputSpec, int], ...]`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants