Fix method meta error in wasm build #13496
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
An error would occur when trying to get the metadata for a method containing an input or output that isn't a tensor. This occurs because there wasn't a check for the input/output tag when generating the list of tensor metadata.
Now the list of tensor metadata will have
undefinedif the input/output in that index is not a tensor.Test plan
Added unit tests to test the method metadata for a method that has ints in its input and outputs.
Added unit test to check if getMethod works if the module has multiple methods.
Unit tests are in the CI but can be ran with