Skip to content

Delete tools/cmake/{buck_util,resolve_buck}.py #13588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Parent: Switch from print_exported_headers to CMake's installed headers in scripts/build_apple_frameworks.sh
wants to merge 2 commits into
base: gh/swolchok/556/head
Choose a base branch
from
Open

Delete tools/cmake/{buck_util,resolve_buck}.py #13588

wants to merge 2 commits into from

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented Aug 21, 2025 •
edited
Loading

We don't need resolve_buck.py in check_for_installed_private_headers_in_cmake_out, so we can just delete it.

@swolchok
Update
4ed78de 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Aug 21, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 21, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13588

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 93e0042 with merge base 335de46 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 21, 2025
swolchok added a commit that referenced this pull request Aug 21, 2025
@swolchok
DRAFT: Does CI need resolve_buck.py to be used in check_for_installed…
59a9634 
…_private_headers_in_cmake_out?

ghstack-source-id: dd3824e
ghstack-comment-id: 3211876811
Pull-Request: #13588
This was referenced Aug 21, 2025
Merged
Open
Open
@swolchok
Update
93e0042 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Aug 21, 2025
@swolchok
Delete tools/cmake/{buck_util,resolve_buck}.py
de6bbd9 
ghstack-source-id: e9bcbf3
ghstack-comment-id: 3211876811
Pull-Request: #13588
@swolchok swolchok changed the title DRAFT: Does CI need resolve_buck.py to be used in check_for_installed_private_headers_in_cmake_out? Delete tools/cmake/{buck_util,resolve_buck}.py Aug 21, 2025
@swolchok swolchok added the release notes: none Do not include this in the release notes label Aug 21, 2025
@swolchok swolchok marked this pull request as ready for review August 21, 2025 22:27
@github-actions
Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes stale PRs inactive for over 60 days

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@swolchok