ET windows build flags #13636
ET windows build flags #13636
Conversation
Add compiler flags for windows msvc builds Differential Revision: [D78854132](https://our.internmc.facebook.com/intern/diff/D78854132/) [ghstack-poisoned]
ivayloen
requested review from
JacobSzwejbka,
lucylq,
manuelcandales and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13636
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 3 Unrelated FailuresAs of commit d536e76 with merge base 7cf8a5e ( NEW FAILURE - The following job has failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78854132 |
This PR needs a
|
| "activation_ops_util.h", | ||
| ], | ||
| compiler_flags = ["-Wno-missing-prototypes"], | ||
| compiler_flags = select({ |
There was a problem hiding this comment.
nit: Can selects be variables
COMMON_UTIL_FLAGS = select...
| ], | ||
| }), | ||
| "ovr_config//os:windows": [], | ||
| "ovr_config//os:windows": ["fbsource//third-party/sleef:sleef"], |
There was a problem hiding this comment.
the way this function is structured seems very strange to me.
Add compiler flags for windows msvc builds Differential Revision: [D78854132](https://our.internmc.facebook.com/intern/diff/D78854132/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D78854132 |
4 participants
Stack from ghstack (oldest at bottom):
Add compiler flags for windows msvc builds
Differential Revision: D78854132