-
Couldn't load subscription status.
- Fork 701
Fix build on Windows, re-enable Windows build CI job #13672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
GregoryComer
wants to merge
76
commits into
main
Choose a base branch
from
gh/GregoryComer/141/head
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
94c4f20
Update
GregoryComer 352c059
Update
GregoryComer d8f8b12
Update
GregoryComer 8e8b78c
Update
GregoryComer 9cfd2b6
Update
GregoryComer 5b1330b
Update
GregoryComer 378fcdd
Update
GregoryComer db12da0
Update
GregoryComer 4ee5cd0
Update
GregoryComer b79f2e1
Update
GregoryComer 0abe592
Update
GregoryComer 34a1470
Update
GregoryComer 923f43e
Update
GregoryComer 1c0407a
Update
GregoryComer 3b79e9d
Update
GregoryComer fc34c14
Update
GregoryComer fa3793a
Update
GregoryComer 52b9ff1
Update
GregoryComer c045a60
Update
GregoryComer 6e6ab75
Update
GregoryComer 783cb51
Update
GregoryComer 0dc6f36
Update
GregoryComer 5fa2464
Update
GregoryComer 597dddd
Update
GregoryComer d78731e
Update
GregoryComer 7b45dac
Update
GregoryComer 6e80b0c
Update
GregoryComer a4f0cd5
Update
GregoryComer 4540ae8
Update
GregoryComer 2d2fbc2
Update
GregoryComer d6a6fe4
Update
GregoryComer 0411181
Update
GregoryComer b9fc97f
Update
GregoryComer 4919b55
Update
GregoryComer b35a1ed
Update
GregoryComer 53e6ba1
Update
GregoryComer 4996713
Update
GregoryComer 0fa419d
Update
GregoryComer 1d7b71d
Update
GregoryComer c1b7820
Update
GregoryComer cd7fd0e
Update
GregoryComer e346888
Update
GregoryComer 28605ca
Update
GregoryComer 4d86231
Update
GregoryComer 77d88d5
Update
GregoryComer efe8513
Update
GregoryComer 35815db
Update
GregoryComer 35e6070
Update
GregoryComer c71aace
Update
GregoryComer 9fbb993
Update
GregoryComer 395d2d4
Update
GregoryComer a2de891
Update
GregoryComer 1423edb
Update
GregoryComer ce55ae8
Update
GregoryComer 57d2e24
Update
GregoryComer 4404db8
Update
GregoryComer c891c21
Update
GregoryComer 68b93ce
Update
GregoryComer e0a7a1d
Update
GregoryComer faf1700
Update
GregoryComer 593055e
Update
GregoryComer 54b32b4
Update
GregoryComer fbe2d44
Update
GregoryComer df4d5fa
Update
GregoryComer efd02e4
Update
GregoryComer 49c71b4
Update
GregoryComer fb9fc9d
Update
GregoryComer d2a3002
Update
GregoryComer 4dd225a
Update
GregoryComer 1b77f7a
Update
GregoryComer 9656f2d
Update
GregoryComer a8edd06
Update
GregoryComer 472df91
Update
GregoryComer 1326917
Update
GregoryComer 488289b
Update
GregoryComer 3a32779
Update
GregoryComer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swolchok It looks like CMake complains when there's an exclude with an empty pattern (see https://github.com/pytorch/executorch/actions/runs/17222786697/job/48861521892, line 818). This is a bit of a pain as there doesn't seem to be an elegant solution to this. Do you have any preferences on this approach?
I suppose we could default the exclude pattern to some string that matches nothing, though that seems a little hacky. It looks like we could also maybe build a list of install args, including the "magic" keywords, though I haven't tried it.