-
Couldn't load subscription status.
- Fork 700
Fix remaining build issues on Windows, re-enable Windows pybind preset build CI job #13702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13702
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 27 PendingAs of commit 7010cf3 with merge base 8dff86a ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Thank you! |
Note: This is a cherry-pick of #13564 and #13259. I inadvertently broke the ghstack when attempting to re-order the stack, leading to the old PR being merged by ghstack into the ghstack-created branch (not main).
Add mman_windows.cpp to the CMake sources. Fix a few build-blocking issues with XNNPACK on Windows. Enable XNNPACK on the Windows preset. This also gives CI coverage.
I've disabled 4 microkernel families that don't build currently. These likely need to be gated or fixed upstream, but I'm disabling them locally for now to unblock usage. They are relatively niche and should have little to no perf impact on the average user.
With this change, the pybind preset works and we can re-enable it in CI.