Skip to content

NXP backend: Fix group convolution merge conflict #13894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergennachin merged 2 commits into from
Sep 3, 2025
Merged

NXP backend: Fix group convolution merge conflict #13894

mergennachin merged 2 commits into from
Sep 3, 2025

Conversation

@mergennachin
Copy link
Contributor

@mergennachin mergennachin commented Sep 3, 2025 •
edited
Loading

Updated version with lint fixes: #13867

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13894

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⏳ No Failures, 31 Pending

As of commit 10952f8 with merge base 8ba92a9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 3, 2025
@github-actions
Copy link

github-actions bot commented Sep 3, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@mergennachin mergennachin merged commit 19a54bc into main Sep 3, 2025
111 of 114 checks passed
@mergennachin mergennachin deleted the upstream/main-nxp/EIEX-520-fix-group-conv-merge-conflict branch September 3, 2025 03:07
@mergennachin mergennachin mentioned this pull request Sep 3, 2025
Closed
@MartinPavella MartinPavella mentioned this pull request Sep 3, 2025
Merged
robert-kalmar pushed a commit that referenced this pull request Sep 3, 2025
@MartinPavella
NXP backend: Fix Neutron unit test (conflicting changes merged) (#13900)
f8a422c 
### Summary
This PR fixes a merge conflict caused by
#13128 and
#13894

### Test plan
Tested by existing unit tests.


cc @digantdesai @JakeStevens @robert-kalmar
lucylq added a commit that referenced this pull request Sep 3, 2025
@lucylq
Revert "NXP backend: Fix group convolution merge conflict (#13894)"
af12daf 
This reverts commit 19a54bc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shoumikhin shoumikhin shoumikhin approved these changes

@JacobSzwejbka JacobSzwejbka JacobSzwejbka approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mergennachin @shoumikhin @JacobSzwejbka @MartinPavella