Skip to content

Deprecate method retrieval in module #13913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 4, 2025
Merged

Deprecate method retrieval in module #13913

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49480ad
Deprecate method retrieval in module
shoumikhin Sep 3, 2025
dea532a
Merge branch 'main' into shoumikhin-patch-2
shoumikhin Sep 3, 2025
97914fa
Format method declaration for better readability
shoumikhin Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion extension/module/module.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,8 @@ class Module {
}

/**
* DEPRECATED: Module manages each Method exclusively.
*
* Get a method by it's name. Not recommended to use this method directly as
* an end user. It's exposed to allow for composability of module in apis that
* operate on method.
Expand All @@ -215,7 +217,8 @@ class Module {
* @returns A Result object containing either a pointer to the requested
* method or an error to indicate failure.
*/
ET_NODISCARD runtime::Result<Method*> method(const std::string& method_name);
ET_DEPRECATED ET_NODISCARD runtime::Result<Method*> method(
const std::string& method_name);

/**
* Load the 'forward' method from the program and set up memory management if
Expand Down
Loading