Skip to content

fix facto contraints to avoid char,byte in full #13966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
facebook-github-bot merged 1 commit into from
Sep 5, 2025
Merged

fix facto contraints to avoid char,byte in full #13966

facebook-github-bot merged 1 commit into from
Sep 5, 2025

Conversation

@zonglinpeng
Copy link
Contributor

@zonglinpeng zonglinpeng commented Sep 4, 2025

Summary: div, mul, add, sub, neg, slice decomp with full. only generate int32 and float32 testcases for these ops

Differential Revision: D81705758

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13966

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 5ea61b9 with merge base f4ec01a (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 4, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 4, 2025

This pull request was exported from Phabricator. Differential Revision: D81705758

@github-actions
Copy link

github-actions bot commented Sep 4, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

zonglinpeng added a commit to zonglinpeng/executorch that referenced this pull request Sep 4, 2025
@zonglinpeng @facebook-github-bot
fix facto contraints to avoid char,byte in full (pytorch#13966)
ed53003 
Summary:

div, mul, add, sub, neg, slice decomp with full. only generate int32 and float32 testcases for these ops

Differential Revision: D81705758
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 4, 2025

This pull request was exported from Phabricator. Differential Revision: D81705758

zonglinpeng added a commit to zonglinpeng/executorch that referenced this pull request Sep 4, 2025
@zonglinpeng @facebook-github-bot
fix facto contraints to avoid char,byte in full (pytorch#13966)
d30f879 
Summary:

div, mul, add, sub, neg, slice decomp with full. only generate int32 and float32 testcases for these ops

Differential Revision: D81705758
@zonglinpeng @facebook-github-bot
fix facto contraints to avoid char,byte in full (pytorch#13966)
5ea61b9 
Summary:
Pull Request resolved: pytorch#13966

div, mul, add, sub, neg, slice decomp with full. only generate int32 and float32 testcases for these ops

Differential Revision: D81705758
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 4, 2025

This pull request was exported from Phabricator. Differential Revision: D81705758

@facebook-github-bot facebook-github-bot merged commit 2261848 into pytorch:main Sep 5, 2025
116 of 120 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomasJannaud ThomasJannaud ThomasJannaud approved these changes

@hsharma35 hsharma35 hsharma35 approved these changes

@manuelcandales manuelcandales Awaiting requested review from manuelcandales

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zonglinpeng @facebook-github-bot @ThomasJannaud @hsharma35