-
Notifications
You must be signed in to change notification settings - Fork 748
Update OSS flow to call the right APIs #13967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D81698817 |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13967
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 10c1f99 with merge base 646e0c4 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
Summary: Reorganize the calls so that we don't run into issues calling `eval()` Reviewed By: zonglinpeng Differential Revision: D81698817
e5cefd2 to
f34aa2f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81698817 |
Summary: Pull Request resolved: #13967 Reorganize the calls so that we don't run into issues calling `eval()` Reviewed By: zonglinpeng Differential Revision: D81698817
f34aa2f to
a413610
Compare
Summary: Reorganize the calls so that we don't run into issues calling `eval()` Reviewed By: zonglinpeng Differential Revision: D81698817
a413610 to
10c1f99
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81698817 |
|
@mcremon-meta Perhaps we can start thinking about having an OSS CI test? |
|
Looks like current tests will run internally but not in OSS. Since you're starting to have OSS contributors, setting up OSS test suite would be good too so that you're all on the same page. |
agreed! We have definitely thought about it :) and it's planned to start this half. Hoping to get some early coverage by EoY and keep improving from there next year. |
Summary: Reorganize the calls so that we don't run into issues calling
eval()Reviewed By: zonglinpeng
Differential Revision: D81698817