Skip to content

Conversation

@mcremon-meta
Copy link
Contributor

Summary: Reorganize the calls so that we don't run into issues calling eval()

Reviewed By: zonglinpeng

Differential Revision: D81698817

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 4, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81698817

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13967

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 10c1f99 with merge base 646e0c4 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link

github-actions bot commented Sep 4, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

mcremon-meta added a commit that referenced this pull request Sep 4, 2025
Summary:

Reorganize the calls so that we don't run into issues calling `eval()`

Reviewed By: zonglinpeng

Differential Revision: D81698817
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81698817

mcremon-meta added a commit that referenced this pull request Sep 4, 2025
Summary:
Pull Request resolved: #13967

Reorganize the calls so that we don't run into issues calling `eval()`

Reviewed By: zonglinpeng

Differential Revision: D81698817
Summary:

Reorganize the calls so that we don't run into issues calling `eval()`

Reviewed By: zonglinpeng

Differential Revision: D81698817
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81698817

@mergennachin
Copy link
Contributor

@mcremon-meta Perhaps we can start thinking about having an OSS CI test?

@mergennachin
Copy link
Contributor

mergennachin commented Sep 4, 2025

Looks like current tests will run internally but not in OSS. Since you're starting to have OSS contributors, setting up OSS test suite would be good too so that you're all on the same page.

@mcremon-meta
Copy link
Contributor Author

@mcremon-meta Perhaps we can start thinking about having an OSS CI test?

agreed! We have definitely thought about it :) and it's planned to start this half. Hoping to get some early coverage by EoY and keep improving from there next year.

@facebook-github-bot facebook-github-bot merged commit 2517376 into main Sep 5, 2025
115 of 118 checks passed
@facebook-github-bot facebook-github-bot deleted the export-D81698817 branch September 5, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants