Skip to content

Conversation

@GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Sep 5, 2025

Skip tests that validate inf and nan edge cases. In hindsight, it's not reasonable to validate these on backends, with varying quantization and precision. I've marked them as skip to allow for manually running as they might have some conceptual value to backend authors.

GregoryComer and others added 3 commits September 4, 2025 17:30
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13990

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 2 Unrelated Failures

As of commit 9a8b717 with merge base ed0ab94 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

GregoryComer added a commit that referenced this pull request Sep 5, 2025
ghstack-source-id: c298968
ghstack-comment-id: 3257173725
Pull-Request: #13990
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 5, 2025
@GregoryComer GregoryComer marked this pull request as ready for review September 5, 2025 06:37
[ghstack-poisoned]
[ghstack-poisoned]
GregoryComer and others added 4 commits September 10, 2025 23:22
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Base automatically changed from gh/GregoryComer/154/head to main September 16, 2025 01:26
@GregoryComer GregoryComer merged commit 48ba0a6 into main Sep 16, 2025
127 of 238 checks passed
@GregoryComer GregoryComer deleted the gh/GregoryComer/155/head branch September 16, 2025 01:27
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
Skip tests that validate inf and nan edge cases. In hindsight, it's not
reasonable to validate these on backends, with varying quantization and
precision. I've marked them as skip to allow for manually running as
they might have some conceptual value to backend authors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants