Skip to content

Conversation

@zingo
Copy link
Collaborator

@zingo zingo commented Sep 5, 2025

This try to fix broke buck2 builds

cc @digantdesai @freddan80 @per @oscarandersson8218

Signed-off-by: Zingo Andersen <[email protected]>
Change-Id: Ia5eafe71055569f97f9f9f518bc958b9c4145b57
@zingo zingo requested a review from digantdesai as a code owner September 5, 2025 13:30
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14006

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit c85bd80 with merge base 01258d2 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 5, 2025
@zingo zingo added ciflow/trunk partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes labels Sep 5, 2025
@zingo
Copy link
Collaborator Author

zingo commented Sep 5, 2025

We have unfortunally no way of knowing if this is correct as the github builds are not buck2 based, but we have tried to dry-code what we think will work for you.

@shoumikhin
Copy link
Contributor

@digantdesai can you please verify if this change fixes the internal issues?

@zingo
Copy link
Collaborator Author

zingo commented Sep 5, 2025

@shoumikhin @digantdesai as we soon are moving out of the local working window :) feel free to just merge this directly when you approve it and not wait for me, as I assume you want to fix this faster them my response time might be, Ill try to keep an eye on it anyway if you don't but it might take a bit of time :)

@zingo
Copy link
Collaborator Author

zingo commented Sep 5, 2025

Fails are unrelated

@digantdesai
Copy link
Contributor

digantdesai commented Sep 5, 2025

Thanks @zingo for the bold attempt, while flying blind. Let me test it.
I think we should enable buck2 AoT unit tests (at least for TOSA) in OSS. Let me do it next week.

@zingo
Copy link
Collaborator Author

zingo commented Sep 6, 2025

A better fix for this was merged #14031

@zingo zingo closed this Sep 6, 2025
@zingo zingo deleted the Arm-backend-Fix-buck2-files-after-moving-TOSA-partitioner branch September 9, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants