Skip to content

Conversation

@ThomasJannaud
Copy link
Contributor

Summary:

  • For some tests, we except a ISSRuntimeFailure. However we re-raise this as a Runtime exception in some cases, which fails some tests
  • We would raise ISSRuntimeFailure both in expected and unexpected cases (and the meaning was that it was expected)

Reviewed By: hsharma35

Differential Revision: D81754432

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14021

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit 1e8b411 with merge base 234c288 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 5, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81754432

@github-actions
Copy link

github-actions bot commented Sep 5, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

…plit ISS...Failure into Expected and Unexpected versions (pytorch#14021)

Summary:

- For some tests, we except a ISSRuntimeFailure. However we re-raise this as a Runtime exception in some cases, which fails some tests
- We would raise ISSRuntimeFailure both in expected and unexpected cases (and the meaning was that it was expected)

Reviewed By: hsharma35

Differential Revision: D81754432
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81754432

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Nov 5, 2025
@ThomasJannaud
Copy link
Contributor Author

abandoned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported stale PRs inactive for over 60 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants