Skip to content

[retake] Use extension module for pybind #14029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2025
Merged

[retake] Use extension module for pybind #14029

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f711db5
[retake] Use extension module for pybind
lucylq Sep 5, 2025
f1e2a5c
Add debug buffer support for pybindings (#14030)
pytorchbot Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions exir/backend/test/test_backends.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,6 @@ def forward(self, a, x, b):

executorch_module = _load_for_executorch_from_buffer(buff)

# pyre-fixme[16]: Module `pytree` has no attribute `tree_flatten`.
inputs_flattened, _ = tree_flatten(model_inputs)
model_output = executorch_module.run_method("forward", tuple(inputs_flattened))
ref_output = add_mul_module(*model_inputs)
Expand Down Expand Up @@ -319,16 +318,17 @@ def forward(self, x):
)

buff = exec_prog.buffer

executorch_module = _load_for_executorch_from_buffer(buff)
# This line should raise an exception like
# RuntimeError: failed with error 0x12
_load_for_executorch_from_buffer(buff)
inputs_flattened, _ = tree_flatten(model_inputs)
executorch_module.run_method("forward", tuple(inputs_flattened))

@vary_segments
def test_backend_with_compiler_out_of_range(self, extract_delegate_segments: bool):
with self.assertRaisesRegex(
RuntimeError,
"loading method forward failed with error 0x12",
"Failed to execute method forward, error: 0x12",
):
self.run_model_in_unsupported_backend(
extract_delegate_segments=extract_delegate_segments
Expand Down Expand Up @@ -876,7 +876,6 @@ def forward(self, a, x, b):
self.assertEqual(counter, 2)

executorch_module = _load_for_executorch_from_buffer(executorch_prog.buffer)
# pyre-fixme[16]: Module `pytree` has no attribute `tree_flatten`.
inputs_flattened, _ = tree_flatten(inputs)
model_output = executorch_module.run_method("forward", tuple(inputs_flattened))
ref_output = m(*inputs)
Expand Down
8 changes: 4 additions & 4 deletions exir/backend/test/test_backends_lifted.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,6 @@ def forward(self, a, x, b):

executorch_module = _load_for_executorch_from_buffer(buff)

# pyre-fixme[16]: Module `pytree` has no attribute `tree_flatten`.
inputs_flattened, _ = tree_flatten(model_inputs)
model_output = executorch_module.run_method("forward", tuple(inputs_flattened))
ref_output = add_mul_module(*model_inputs)
Expand Down Expand Up @@ -347,15 +346,17 @@ def forward(self, x):

buff = exec_prog.buffer

executorch_module = _load_for_executorch_from_buffer(buff)
# This line should raise an exception like
# RuntimeError: failed with error 0x12
_load_for_executorch_from_buffer(buff)
inputs_flattened, _ = tree_flatten(model_inputs)
executorch_module.run_method("forward", tuple(inputs_flattened))

@vary_segments
def test_backend_with_compiler_out_of_range(self, extract_delegate_segments: bool):
with self.assertRaisesRegex(
RuntimeError,
"loading method forward failed with error 0x12",
"Failed to execute method forward, error: 0x12",
):
self.run_model_in_unsupported_backend(
extract_delegate_segments=extract_delegate_segments
Expand Down Expand Up @@ -887,7 +888,6 @@ def forward(self, a, x, b):
self.assertEqual(counter, 2)

executorch_module = _load_for_executorch_from_buffer(executorch_prog.buffer)
# pyre-fixme[16]: Module `pytree` has no attribute `tree_flatten`.
inputs_flattened, _ = tree_flatten(inputs)
model_output = executorch_module.run_method("forward", tuple(inputs_flattened))
ref_output = m(*inputs)
Expand Down
10 changes: 6 additions & 4 deletions exir/backend/test/test_compatibility.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,13 @@ def forward(self, x):
)
)

executorch_module = _load_for_executorch_from_buffer(buff)
# Throw runtime error with error code 0x30, meaning delegate is incompatible.
with self.assertRaisesRegex(
RuntimeError,
"loading method forward failed with error 0x30",
"Failed to execute method forward, error: 0x30",
):
executorch_module = _load_for_executorch_from_buffer(buff)
executorch_module.run_method("forward")

def test_compatibility_in_runtime_edge_program_manager(self):
class SinModule(torch.nn.Module):
Expand Down Expand Up @@ -108,9 +109,10 @@ def forward(self, x):
)
)

executorch_module = _load_for_executorch_from_buffer(buff)
# Throw runtime error with error code 0x30, meaning delegate is incompatible.
with self.assertRaisesRegex(
RuntimeError,
"loading method forward failed with error 0x30",
"Failed to execute method forward, error: 0x30",
):
executorch_module = _load_for_executorch_from_buffer(buff)
executorch_module.run_method("forward")
Loading
Loading