Ensure we can call custom ops from torch cadence lib #14034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14034
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 65 Pending, 1 Unrelated FailureAs of commit dc161a8 with merge base 57173d9 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81738196 |
This PR needs a
|
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 6, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 6, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 6, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 8, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
force-pushed
the
export-D81738196
branch
from
b282a29 to
3537035
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 8, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81738196 |
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 8, 2025
Summary: Pull Request resolved: pytorch#14034 Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
force-pushed
the
export-D81738196
branch
from
3537035 to
607ee24
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 8, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 8, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 8, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
hsharma35
approved these changes
Sep 8, 2025
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 8, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 8, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 8, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 9, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
force-pushed
the
export-D81738196
branch
from
607ee24 to
e8c0133
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81738196 |
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 9, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 9, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 9, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
force-pushed
the
export-D81738196
branch
from
e8c0133 to
cbe926f
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 9, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 9, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 9, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 9, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 9, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81738196 |
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 9, 2025
Summary: Pull Request resolved: pytorch#14034 Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
force-pushed
the
export-D81738196
branch
from
cbe926f to
a09819b
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 9, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 9, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 9, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 9, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
force-pushed
the
export-D81738196
branch
from
a09819b to
5d31bc4
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 9, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 9, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81738196 |
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 9, 2025
Summary: Pull Request resolved: pytorch#14034 Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
force-pushed
the
export-D81738196
branch
from
5d31bc4 to
01a80f6
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 10, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 10, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 10, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 10, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
force-pushed
the
export-D81738196
branch
from
01a80f6 to
144f679
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 10, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 10, 2025
Summary: Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
Summary: Pull Request resolved: pytorch#14034 Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well. Tests now use the torch cadence custom op library. Reviewed By: hsharma35 Differential Revision: D81738196
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81738196 |
DrJessop
force-pushed
the
export-D81738196
branch
from
144f679 to
dc161a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes mismatches between op registration names and implementation names, fixes some type issues in tests where unexpected types are passed in given the op definition. Also fixes an incorrect layernorm meta op (normalized_shape should be list, not int). Tests corrected as well.
Tests now use the torch cadence custom op library.
Reviewed By: hsharma35
Differential Revision: D81738196