Remove non-per-tensor quantized add and replace with per-tensor variant #14093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14093
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 92 PendingAs of commit a526b61 with merge base 0b4fe31 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81950579 |
This PR needs a
|
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 8, 2025
…nt (pytorch#14093) Summary: As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Differential Revision: D81950579
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 8, 2025
…nt (pytorch#14093) Summary: As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Differential Revision: D81950579
DrJessop
force-pushed
the
export-D81950579
branch
from
d8516e8 to
f45dc38
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 9, 2025
…nt (pytorch#14093) Summary: As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Differential Revision: D81950579
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 9, 2025
…nt (pytorch#14093) Summary: As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Differential Revision: D81950579
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 9, 2025
…nt (pytorch#14093) Summary: As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Differential Revision: D81950579
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 9, 2025
…nt (pytorch#14093) Summary: As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Differential Revision: D81950579
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81950579 |
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 9, 2025
…nt (pytorch#14093) Summary: Pull Request resolved: pytorch#14093 As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Differential Revision: D81950579
DrJessop
force-pushed
the
export-D81950579
branch
from
f45dc38 to
54950c0
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 9, 2025
…nt (pytorch#14093) Summary: As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Differential Revision: D81950579
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 9, 2025
…nt (pytorch#14093) Summary: As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Differential Revision: D81950579
DrJessop
force-pushed
the
export-D81950579
branch
from
54950c0 to
7c3e336
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 9, 2025
…nt (pytorch#14093) Summary: As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Differential Revision: D81950579
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81950579 |
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 9, 2025
…nt (pytorch#14093) Summary: Pull Request resolved: pytorch#14093 As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Differential Revision: D81950579
DrJessop
force-pushed
the
export-D81950579
branch
from
7c3e336 to
0fd1c87
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 10, 2025
…nt (pytorch#14093) Summary: As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Differential Revision: D81950579
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 10, 2025
…nt (pytorch#14093) Summary: As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Differential Revision: D81950579
DrJessop
force-pushed
the
export-D81950579
branch
from
0fd1c87 to
710e60d
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 10, 2025
…nt (pytorch#14093) Summary: As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Differential Revision: D81950579
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81950579 |
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 10, 2025
…nt (pytorch#14093) Summary: Pull Request resolved: pytorch#14093 As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Differential Revision: D81950579
DrJessop
force-pushed
the
export-D81950579
branch
from
710e60d to
e405754
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 10, 2025
…nt (pytorch#14093) Summary: As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Differential Revision: D81950579
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 10, 2025
…nt (pytorch#14093) Summary: As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Differential Revision: D81950579
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81950579 |
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 10, 2025
…nt (pytorch#14093) Summary: Pull Request resolved: pytorch#14093 As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Differential Revision: D81950579
DrJessop
force-pushed
the
export-D81950579
branch
from
cf81c51 to
5311b19
Compare
hsharma35
approved these changes
Sep 10, 2025
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 11, 2025
…nt (pytorch#14093) Summary: As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Reviewed By: hsharma35 Differential Revision: D81950579
DrJessop
force-pushed
the
export-D81950579
branch
from
5311b19 to
fa689ac
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 11, 2025
…nt (pytorch#14093) Summary: As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Reviewed By: hsharma35 Differential Revision: D81950579
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 11, 2025
…nt (pytorch#14093) Summary: As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Reviewed By: hsharma35 Differential Revision: D81950579
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81950579 |
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 11, 2025
…nt (pytorch#14093) Summary: Pull Request resolved: pytorch#14093 As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Reviewed By: hsharma35 Differential Revision: D81950579
DrJessop
force-pushed
the
export-D81950579
branch
2 times, most recently
from
57b1705 to
be6c7e8
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 11, 2025
…nt (pytorch#14093) Summary: As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Reviewed By: hsharma35 Differential Revision: D81950579
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 11, 2025
…nt (pytorch#14093) Summary: As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Reviewed By: hsharma35 Differential Revision: D81950579
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 11, 2025
…nt (pytorch#14093) Summary: As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Reviewed By: hsharma35 Differential Revision: D81950579
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81950579 |
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 11, 2025
…nt (pytorch#14093) Summary: Pull Request resolved: pytorch#14093 As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Reviewed By: hsharma35 Differential Revision: D81950579
DrJessop
force-pushed
the
export-D81950579
branch
2 times, most recently
from
679d685 to
d9c1ad4
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 13, 2025
…nt (pytorch#14093) Summary: As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Reviewed By: hsharma35 Differential Revision: D81950579
Contributor
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 13, 2025
…nt (pytorch#14093) Summary: As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Reviewed By: hsharma35 Differential Revision: D81950579
…nt (pytorch#14093) Summary: As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Reviewed By: hsharma35 Differential Revision: D81950579
DrJessop
force-pushed
the
export-D81950579
branch
from
d9c1ad4 to
a526b61
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 13, 2025
…nt (pytorch#14093) Summary: As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations. Reviewed By: hsharma35 Differential Revision: D81950579
Contributor
StrycekSimon
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Sep 23, 2025
Differential Revision: D81950579 Pull Request resolved: pytorch#14093
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As discussed offline, we don't need a non-per-tensor variant of quantized_add, so removing from ref implementations.
Differential Revision: D81950579