Skip to content

Java Remove generateFromPos API #14102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kirklandsign merged 7 commits into from
Sep 10, 2025
Merged

Java Remove generateFromPos API #14102

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
efe81ee
LlmModule prefill refactor
kirklandsign Sep 9, 2025
015a6ab
Doing some rename
kirklandsign Sep 9, 2025
16b6d1c
Java layer no longer need a separate generateFromPos
kirklandsign Sep 9, 2025
e08df47
Remove generateFromPos API
kirklandsign Sep 9, 2025
01c8692
Merge remote-tracking branch 'origin/main' into start-pos-api-llava-7
kirklandsign Sep 10, 2025
c40ab7c
Merge remote-tracking branch 'origin/main' into start-pos-api-llava-7
kirklandsign Sep 10, 2025
10f621b
Lint
kirklandsign Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...pps/android/LlamaDemo/app/src/main/java/com/example/executorchllamademo/MainActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,10 +778,9 @@ public void run() {
mCurrentSettingsFields.getModelType(),
mCurrentSettingsFields.getBackendType())
== ModelUtils.VISION_MODEL) {
mModule.generateFromPos(
mModule.generate(
finalPrompt,
ModelUtils.VISION_MODEL_SEQ_LEN,
startPos,
MainActivity.this,
false);
} else if (mCurrentSettingsFields.getModelType() == ModelType.LLAMA_GUARD_3) {
Expand Down
18 changes: 0 additions & 18 deletions ...roid/executorch_android/src/main/java/org/pytorch/executorch/extension/llm/LlmModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,24 +218,6 @@ public long prefillPrompt(String prompt, long startPos, int bos, int eos) {
// returns a tuple of (status, updated startPos)
private native int appendTextInput(String prompt, int bos, int eos);

/**
* Generate tokens from the given prompt, starting from the given position.
*
* <p>This is a deprecated API. Please use {@link #generate(String, int, LlmCallback, boolean)}
*
* @param prompt The text prompt to LLaVA.
* @param seqLen The total sequence length, including the prompt tokens and new tokens.
* @param startPos The starting position in KV cache of the input in the LLM.
* @param callback callback object to receive results.
* @param echo indicate whether to echo the input prompt or not.
* @return The error code.
*/
@Deprecated
public int generateFromPos(
String prompt, int seqLen, long startPos, LlmCallback callback, boolean echo) {
return generate(prompt, seqLen, callback, echo);
}

/**
* Reset the context of the LLM. This will clear the KV cache and reset the state of the LLM.
*
Expand Down
Loading