Skip to content

Conversation

@zingo
Copy link
Collaborator

@zingo zingo commented Sep 9, 2025

Arm backend: Update weight observer for QAT

Updates weight observer for QAT+per-channel. Also adds a simple test to
test QAT flow.

Signed-off-by: Oscar Andersson <[email protected]>

cc @digantdesai @freddan80 @per @oscarandersson8218

oscarandersson8218 and others added 2 commits September 9, 2025 16:19
Updates weight observer for QAT+per-channel. Also adds a simple test to
test QAT flow.

Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: I49a2a9de442d7c55bef03ab5038356b9dab2d1c5
Updates weight observer for QAT+per-channel. Also adds a simple test to
test QAT flow.

Signed-off-by: Zingo Andersen <[email protected]>
Change-Id: I69531add22ae4c7a3912916d6fc46fde0217e8df
@zingo zingo requested a review from digantdesai as a code owner September 9, 2025 14:27
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14115

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 3 Cancelled Jobs, 37 Pending, 2 Unrelated Failures

As of commit 389ba62 with merge base 0cac45b (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2025
@zingo zingo added release notes: none Do not include this in the release notes partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm labels Sep 9, 2025
@zingo
Copy link
Collaborator Author

zingo commented Sep 9, 2025

@digantdesai this is a fix on a commet you made in #13511

@zingo zingo added this to the 1.0.0 milestone Sep 9, 2025
@zingo zingo changed the title Arm backend update weight observer for qat Arm backend Update weight observer for QAT Sep 9, 2025
@zingo zingo changed the title Arm backend Update weight observer for QAT Arm backend: Update weight observer for QAT Sep 10, 2025
@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this in D82259448.

@digantdesai
Copy link
Contributor

Internal CI looks green. We can merge it once GH CI is green.

@digantdesai digantdesai merged commit 0e9d871 into pytorch:main Sep 12, 2025
289 of 299 checks passed
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
@zingo zingo deleted the Arm-backend-Update-weight-observer-for-QAT branch October 3, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants