Skip to content

Arm backend: Remove _vgf_ op pytest xfails #14116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mansnils merged 1 commit into from
Sep 9, 2025
Merged

Arm backend: Remove _vgf_ op pytest xfails #14116

mansnils merged 1 commit into from
Sep 9, 2025

Conversation

@mansnils
Copy link
Collaborator

@mansnils mansnils commented Sep 9, 2025 •
edited by pytorch-bot bot
Loading

Use VK_LAYER_PATH instead of VK_ADD_LAYER_PATH when setting up mlsdk deps since looks like some loaders ignore VK_ADD_LAYER_PATH.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

@mansnils
Arm backend: Remove _vgf_ op pytest xfails
a2b76e9 
Use VK_LAYER_PATH instead of VK_ADD_LAYER_PATH when setting up mlsdk
deps since looks like some loaders ignore VK_ADD*.

Change-Id: I82520ceb900d91bb37abbb30d9e130790656a4e5
@mansnils mansnils added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Sep 9, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 9, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14116

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 17 Pending

As of commit a2b76e9 with merge base 245630a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2025
@zingo zingo mentioned this pull request Sep 9, 2025
Merged
zingo
zingo approved these changes Sep 9, 2025
View reviewed changes
Copy link
Collaborator

@zingo zingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be merged at the same time / together with #14017 when tests has passed OK.

@zingo zingo added this to the 1.0.0 milestone Sep 9, 2025
@zingo zingo added the release notes: none Do not include this in the release notes label Sep 9, 2025
@mansnils mansnils merged commit 465e65f into pytorch:main Sep 9, 2025
461 of 462 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zingo zingo zingo approved these changes

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mansnils @zingo