Arm backend: Fix off by one bug in print from arm_executor_runner #14120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perheld
added
module: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14120
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8eb48a8 with merge base 8973eeb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
The arm executor runner has ET_NUM_INFERENCES set to 1 by default but the print after run stated it has done 2 runs. The for loop doing the execution started on 1 and checked with <= causing the num_inferences to tick over by one. Signed-off-by: [email protected] Change-Id: I2aab4ea5ce95635a1ec4c2b8cd82ee5f4a78e1a4
perheld
force-pushed
the
ph-inferences-run-off-by-one
branch
from
e2e98ee to
53c9912
Compare
zingo
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arm executor runner has ET_NUM_INFERENCES set to 1 by default but the print after run stated it has done 2 runs.
The for loop doing the execution started on 1 and checked with <= causing the num_inferences to tick over by one.
Signed-off-by: [email protected]
Change-Id: I2aab4ea5ce95635a1ec4c2b8cd82ee5f4a78e1a4