Skip to content

Conversation

svekars
Copy link
Contributor

@svekars svekars commented Sep 9, 2025

No description provided.

Copy link

pytorch-bot bot commented Sep 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14122

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 24 Pending

As of commit 2c3153a with merge base e45f680 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2025
@svekars svekars marked this pull request as ready for review September 29, 2025 20:15
@mergennachin
Copy link
Contributor

@svekars

How ready is pytorch_sphinx_theme2?

We cut our 1.0 branch about two weeks ago. Do you recommend cherry-picking to 1.0?

@svekars
Copy link
Contributor Author

svekars commented Sep 29, 2025

How ready is pytorch_sphinx_theme2?

We use it in pytorch in the stable branch: https://docs.pytorch.org/docs/stable/index.html and a few other repositories already.
The theme you have right now has an outdated top navigation bar which will not be updated.

@GregoryComer
Copy link
Member

Regarding the 1.0 release, my opinion is that we should merge these changes soon/now and and pick onto the release branch rather than waiting for after 1.0. As mentioned, if we land on main, we'll want to make sure we pick to make sure doc picks don't conflict. These changes would be good to have for 1.0, as well as for the TOC / doc overhaul that @psiddh is driving.

@mergennachin
Copy link
Contributor

Thanks @svekars for the context. Glad that it is already stable.

Okay @GregoryComer @psiddh - please review this and land ASAP in both main and release branches, and start cherry-picking docs changes on top of this PR.

@GregoryComer
Copy link
Member

@svekars We're good to merge the changes. I saw you just rebased the PR. Are there any additional changes you're making, or is this just checking against the latest?

@svekars
Copy link
Contributor Author

svekars commented Sep 30, 2025

@GregoryComer I think this should be good to go.

@GregoryComer GregoryComer merged commit 9a03416 into main Sep 30, 2025
139 checks passed
@GregoryComer GregoryComer deleted the update-theme2 branch September 30, 2025 18:33
@GregoryComer
Copy link
Member

@pytorchbot cherry-pick --onto release/1.0 -c docs

pytorchbot pushed a commit that referenced this pull request Sep 30, 2025
@pytorchbot
Copy link
Collaborator

Cherry picking #14122

The cherry pick PR is at #14704 The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants