-
Notifications
You must be signed in to change notification settings - Fork 688
Migrate to pytorch_sphinx_theme2 #14122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14122
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 24 PendingAs of commit 2c3153a with merge base e45f680 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
bda7cd9
to
8c5271a
Compare
How ready is pytorch_sphinx_theme2? We cut our 1.0 branch about two weeks ago. Do you recommend cherry-picking to 1.0? |
We use it in pytorch in the stable branch: https://docs.pytorch.org/docs/stable/index.html and a few other repositories already. |
Regarding the 1.0 release, my opinion is that we should merge these changes soon/now and and pick onto the release branch rather than waiting for after 1.0. As mentioned, if we land on main, we'll want to make sure we pick to make sure doc picks don't conflict. These changes would be good to have for 1.0, as well as for the TOC / doc overhaul that @psiddh is driving. |
Thanks @svekars for the context. Glad that it is already stable. Okay @GregoryComer @psiddh - please review this and land ASAP in both main and release branches, and start cherry-picking docs changes on top of this PR. |
@svekars We're good to merge the changes. I saw you just rebased the PR. Are there any additional changes you're making, or is this just checking against the latest? |
@GregoryComer I think this should be good to go. |
@pytorchbot cherry-pick --onto release/1.0 -c docs |
(cherry picked from commit 9a03416)
Cherry picking #14122The cherry pick PR is at #14704 The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
No description provided.