Fix XNNPACK handling of negative permute dims #14169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14169
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 21 PendingAs of commit 26d60f2 with merge base 8a0a25b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
metascroy
approved these changes
Sep 11, 2025
GregoryComer
added
the
release notes: none
swolchok
reviewed
Sep 11, 2025
|
|
||
| # Handle negative dimensions by converting them to positive indices | ||
| permute_order = [ | ||
| (dim + input_rank) if dim < 0 else dim for dim in permute_order |
Contributor
There was a problem hiding this comment.
is it possible that dim + input_rank is still negative?
Member
Author
There was a problem hiding this comment.
Good question. I just tried in eager mode, and it seems to enforce that dims are in the range of [-rank, rank-1] inclusive.
>>> temp = torch.randn(1,2,3,4,5)
>>> temp.permute(-9, 2, 3, 4, 0)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
IndexError: Dimension out of range (expected to be in range of [-5, 4], but got -9)
StrycekSimon
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Sep 23, 2025
### Summary Fix handling of negative dims in permute ops on XNNPACK. They currently fail to lower. This bug was surfaced by the backend operator test suite. ### Test plan I've added a test to cover negative dims in permute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix handling of negative dims in permute ops on XNNPACK. They currently fail to lower. This bug was surfaced by the backend operator test suite.
Test plan
I've added a test to cover negative dims in permute.