[ET-VK][DCE] Remove redundant quantized linear implementations #14198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
requested review from
SS-JIA,
jackzhxng,
larryliu0820,
lucylq,
mergennachin and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14198
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 99 PendingAs of commit 5045a35 with merge base 1d37845 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Pull Request resolved: #14151 As title. With the recent support added for dynamically quantized + weight only quantized int4 and int8 linear, which are consolidated under `QuantizedLinear.cpp`, the operators implemented in `QuantizedLinearQGANW.cpp` and `QuantizedLinear_QTA8A_QGA4W.cpp` are no longer required. This diff removes all code related to the operators implemented in those files, namely: * `et_vk.linear_weight_int4.default` * `et_vk.linear_qta8a_qga4w.default` AOT export logic needed to support those ops are also removed. ghstack-source-id: 308939585 Differential Revision: [D82120824](https://our.internmc.facebook.com/intern/diff/D82120824/)
SS-JIA
force-pushed
the
gh/SS-JIA/326/orig
branch
from
6782695 to
5045a35
Compare
SS-JIA
approved these changes
Sep 11, 2025
This PR needs a
|
StrycekSimon
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Sep 23, 2025
…ch#14198) As title. With the recent support added for dynamically quantized + weight only quantized int4 and int8 linear, which are consolidated under `QuantizedLinear.cpp`, the operators implemented in `QuantizedLinearQGANW.cpp` and `QuantizedLinear_QTA8A_QGA4W.cpp` are no longer required. This diff removes all code related to the operators implemented in those files, namely: * `et_vk.linear_weight_int4.default` * `et_vk.linear_qta8a_qga4w.default` AOT export logic needed to support those ops are also removed. Differential Revision: [D82120824](https://our.internmc.facebook.com/intern/diff/D82120824/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #14151 by @SS-JIA
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/326/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/326/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/325/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/326/orig
@diff-train-skip-merge