Skip to content

Conversation

@pytorchbot
Copy link
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #14172 by @Gasoonjia
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/41/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/41/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/41/orig
@diff-train-skip-merge

Pull Request resolved: #14172

make et.runtime support etdump generation.
ghstack-source-id: 308980477
@exported-using-ghexport

Differential Revision: [D80373976](https://our.internmc.facebook.com/intern/diff/D80373976/)
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14205

Note: Links to docs will display an error until the docs builds have been completed.

❌ 15 New Failures, 3 Pending, 4 Unrelated Failures

As of commit 2aedabb with merge base 598ba46 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 11, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

if (result.buf != nullptr && result.size > 0) {
write_data_to_file(path, result.buf, result.size);
free(result.buf);
if (debug_buffer_size_ > 0 &&
Copy link
Collaborator

@zingo zingo Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of using to total size of the debugbuffer you can dig out the actual used size with something like

size_t outputdump_len = etdump_gen->get_data_sink()->get_used_bytes();

Then the file size can match the data, and also only be saved if actual data is put in the area.
I recently did this here #14143 for the arm ethos-u runner that you can look at for inspiration.

@mergennachin mergennachin self-requested a review September 11, 2025 12:02
@mergennachin mergennachin merged commit 2805a81 into main Sep 11, 2025
105 of 126 checks passed
@mergennachin mergennachin deleted the gh/gasoonjia/41/orig branch September 11, 2025 12:02
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: pytorch#14172 by
@Gasoonjia
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/gasoonjia/41/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/gasoonjia/41/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/gasoonjia/41/orig
@diff-train-skip-merge

Co-authored-by: gasoonjia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants