-
Notifications
You must be signed in to change notification settings - Fork 698
support etdump generation in executorch.runtime #14205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request resolved: #14172 make et.runtime support etdump generation. ghstack-source-id: 308980477 @exported-using-ghexport Differential Revision: [D80373976](https://our.internmc.facebook.com/intern/diff/D80373976/)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14205
Note: Links to docs will display an error until the docs builds have been completed. ❌ 15 New Failures, 3 Pending, 4 Unrelated FailuresAs of commit 2aedabb with merge base 598ba46 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
| if (result.buf != nullptr && result.size > 0) { | ||
| write_data_to_file(path, result.buf, result.size); | ||
| free(result.buf); | ||
| if (debug_buffer_size_ > 0 && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of using to total size of the debugbuffer you can dig out the actual used size with something like
size_t outputdump_len = etdump_gen->get_data_sink()->get_used_bytes();
Then the file size can match the data, and also only be saved if actual data is put in the area.
I recently did this here #14143 for the arm ethos-u runner that you can look at for inspiration.
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#14172 by @Gasoonjia ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/41/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/41/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/41/orig @diff-train-skip-merge Co-authored-by: gasoonjia <[email protected]>
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #14172 by @Gasoonjia
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/41/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/41/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/41/orig
@diff-train-skip-merge