Skip to content

Arm backend: make compile_spec API backwards compatible #14209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Erik-Lundell wants to merge 3 commits into from
Closed

Arm backend: make compile_spec API backwards compatible #14209

Erik-Lundell wants to merge 3 commits into from

Conversation

@Erik-Lundell
Copy link
Collaborator

@Erik-Lundell Erik-Lundell commented Sep 11, 2025 •
edited by pytorch-bot bot
Loading

mergennachin and others added 3 commits September 11, 2025 04:37
@mergennachin @facebook-github-bot
Arm backend: Refactor compile spec handling (Try 2) (pytorch#14191)
e221b8d 
Summary:
Pull Request resolved: pytorch#14191

Redoing pytorch#14111 with additional fixes

Differential Revision: D82171193
@Erik-Lundell
Arm backend: make compile_spec API backwards compatible
6acb4ae 
Signed-off-by: Erik Lundell <[email protected]>
Change-Id: Ib28f3390650cb5cf08a1471c2217f4e24167e9bc
@Erik-Lundell
Arm backend: Fix bucket TARGET file
f0b11c5 
Signed-off-by: Erik Lundell <[email protected]>
Change-Id: I872705544f9130f1999907a84ad1eb1484f9b850
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14209

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Cancelled Job, 5 Unrelated Failures

As of commit f0b11c5 with merge base 6ed10e5 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 11, 2025
Erik-Lundell
Erik-Lundell commented Sep 11, 2025
View reviewed changes
backends/arm/TARGETS
Copy link
Collaborator Author

@Erik-Lundell Erik-Lundell Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a guess

@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Sep 11, 2025
@zingo zingo added the release notes: arm Changes to the ARM backend delegate label Sep 11, 2025
@zingo zingo added this to the 1.0.0 milestone Sep 11, 2025
@zingo
Copy link
Collaborator

zingo commented Sep 12, 2025 •
edited
Loading

NOTE: Only merge if @mergennachin wants it #14191 will probably solve this and this might not be needed.

@mergennachin
Copy link
Contributor

mergennachin commented Sep 12, 2025

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Erik-Lundell @zingo @mergennachin