Remove torchcodec from install_requirements.py #14211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: torchcodec is used when only torchaudio users use torch.save and torch.load. It is an optional requirement. Only moshi test uses torch.save and torch.load, and we should make this to install across the board. Currently, it is blocking linux aarch64 wheel building (#13946) because during smoke testing it is trying to install torchcodec on linux aarch64 machine and it is failing
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14211
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 6 Unrelated FailuresAs of commit dfccb1c with merge base 2805a81 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
NicolasHug
approved these changes
Sep 11, 2025
digantdesai
approved these changes
Sep 11, 2025
StrycekSimon
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Sep 23, 2025
Summary: torchcodec is used when only torchaudio users use torch.save and torch.load. It is an optional requirement. Only moshi test uses torch.save and torch.load, and we shouldn't make this to install across the board. Currently, it is blocking linux aarch64 wheel building (pytorch#13946) because during smoke testing it is trying to install torchcodec on linux aarch64 machine and it is failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
torchcodec is used when only torchaudio users use torch.save and torch.load. It is an optional requirement.
Only moshi test uses torch.save and torch.load, and we shouldn't make this to install across the board.
Currently, it is blocking linux aarch64 wheel building (#13946) because during smoke testing it is trying to install torchcodec on linux aarch64 machine and it is failing