Swap Llava export arg order #14238
Merged
Swap Llava export arg order #14238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14238
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New Failures, 1 Cancelled Job, 37 Pending, 1 Unrelated FailureAs of commit 3a800cb with merge base 6d8583d ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
kirklandsign
approved these changes
Sep 11, 2025
| def _get_prompt_dynamic_shapes(self): | ||
| dim = torch.export.Dim("token_dim", min=2, max=self.max_seq_len) | ||
| text_model_dynamic_shapes = ({0: 1}, {1: dim}) | ||
| text_model_dynamic_shapes = ({1: dim}, {0: 1}) |
Contributor
There was a problem hiding this comment.
nit: 1 and 0 are the dims of a single tensor. So swapping doesnt do anything
Contributor
There was a problem hiding this comment.
also do you even have to specify that the batch is static 1?
Contributor
Author
There was a problem hiding this comment.
{0:1} is the dynamic shapes for the first arg, {1:dim} is for the second arg, so I swap them here
Contributor
Author
|
@pytorchbot cherry-pick --onto release/1.0 -c feature |
|
❌ 🤖 pytorchbot command failed: Try |
Contributor
Author
|
@pytorchbot cherry-pick --onto release/1.0 -c critical |
pytorchbot
pushed a commit
that referenced
this pull request
Sep 16, 2025
Swaps Llava export arg order, such that forward takes `embeddings, cache_position`, instead of `cache_position, embeddings`. (cherry picked from commit 23acfea)
Collaborator
Cherry picking #14238The cherry pick PR is at #14344 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
StrycekSimon
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Sep 23, 2025
Swaps Llava export arg order, such that forward takes `embeddings, cache_position`, instead of `cache_position, embeddings`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Swaps Llava export arg order, such that forward takes
embeddings, cache_position, instead ofcache_position, embeddings.Test plan
Existing Llava tests