Skip to content

Conversation

@swolchok
Copy link
Contributor

Two reasons:

  1. It will end up spamming pip install -r requirements-dev.txt once for each linter because of the way we have init commands set up. This is fixable, but:
  2. setup_linux sets up lintrunner for us already anyway via install_requirements.

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Sep 12, 2025

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14263

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 24 Pending

As of commit acd1eb4 with merge base e6b9111 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Sep 12, 2025
Two reasons:
1) It will end up spamming pip install -r requirements-dev.txt once for each linter because of the way we have init commands set up. This is fixable, but:
2) setup_linux sets up lintrunner for us already anyway via install_requirements.


ghstack-source-id: 243e923
ghstack-comment-id: 3286097617
Pull-Request: #14263
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@swolchok
Copy link
Contributor Author

hmm, this is not much if any faster, guess the split jobs were a good idea and so is not running on all files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants