-
Notifications
You must be signed in to change notification settings - Fork 752
Arm backend: Split Arm tutorial into ethosu and vgf #14299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14299
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 8476448 with merge base f6a5fa0 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@zingo @Erik-Lundell @agrima1304 There are four pages now... https://docs.pytorch.org/executorch/main/backends-arm-ethos-u.html and these two tutorial pages What's the long term plan? |
docs/source/tutorial-arm-ethos-u.md
Outdated
| @@ -0,0 +1,215 @@ | |||
| # Arm® Ethos™-U NPU Backend Tutorial | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
® and &trade in title feels odd - too corporate :p
We can put it somewhere on the page that Arm is a registered trademark etc..
I am not a lawyer :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the interest of time and to stay consistent with our backend docs, I'll keep this for now. We can follow up on this later. (I am also not a lawyer so I'd have to do some looking-into-the-matter)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it :)
docs/source/index.md
Outdated
| Building an ExecuTorch Android Demo App <https://github.com/pytorch-labs/executorch-examples/tree/main/dl3/android/DeepLabV3Demo#executorch-android-demo-app> | ||
| Building an ExecuTorch iOS Demo App <https://github.com/meta-pytorch/executorch-examples/tree/main/mv3/apple/ExecuTorchDemo> | ||
| tutorial-arm.md | ||
| tutorial-arm-ethosu.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do see this https://docs- preview.pytorch.org/pytorch/executorch/14299/backends-arm-vgf.html but not under backends, is that intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is fixed here? 3acd431
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm , I see what you mean now. I get the same problems with the tutorials, only the VGF tutorial shows up in the sidebar 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it was a typo 🥇 Fingers crossed that this is last adjustment
docs/source/tutorial-arm-vgf.md
Outdated
| @@ -0,0 +1,216 @@ | |||
| Arm® VGF Backend Tutorial | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here about ®
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/vgf/Vulkan Graph Format/ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fun fact - VGF does not stand for that :)
digantdesai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just skimmed, stamping to unblock.
If you want this to get cherry-picked please mention it in 1.0 release tracker.
Our plan is that the tutorials essentially are an online version of the minimal_example Jupyter notebooks, for people that don't clone the repo. They are a step-by-step guides on how to do your first lowering. The backend documents all public API and some additional information about the target (Partitioner, Quantizer, CompileSpec, Ethos-U memory modes etc.) Since the backends are for very separate targets, I don't think it makes sense to mix them, even if the code looks rather similar. |
d4b82eb to
b8566bc
Compare
be25c95 to
d9a6b74
Compare
Align with minimal examples with regards to content and code. Signed-off-by: Erik Lundell <[email protected]> Change-Id: Iaa2a8abc46483c3f2cd4313212ea58284804fd65
d9a6b74 to
8476448
Compare
|
Yeah I think treating ethos and vgf as completely independent backend from a user reading a doc is the right approach. And for a given backend, my thinking for backend dev page and a backend [tutorial] page is that, the backend dev page talks about architecture, internals - something like a big picture design which you can't glean easily from reading the code or makes life much easier for someone wants to understand the code base before contributing. For tutorial is more like for a user trying to "try out" the backend without necessarily learning about the internal details. https://docs.divio.com/documentation-system/ for XNNPACK (not in the best shape today) but |
I really like that classification, thanks! |
|
@pytorchbot cherry-pick --onto release/1.0 -c docs |
Align with minimal examples with regards to content and code. Signed-off-by: Erik Lundell <[email protected]> (cherry picked from commit d25c35a)
Cherry picking #14299The cherry pick PR is at #14372 The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
Align with minimal examples with regards to content and code. Signed-off-by: Erik Lundell <[email protected]>


Align with minimal examples with regards to content and code.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218