Skip to content

Conversation

@Erik-Lundell
Copy link
Collaborator

@Erik-Lundell Erik-Lundell commented Sep 15, 2025

Align with minimal examples with regards to content and code.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate labels Sep 15, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14299

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 8476448 with merge base f6a5fa0 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 15, 2025
@zingo zingo added this to the 1.0.0 milestone Sep 15, 2025
@mergennachin
Copy link
Contributor

@@ -0,0 +1,215 @@
# Arm® Ethos™-U NPU Backend Tutorial
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&reg and &trade in title feels odd - too corporate :p
We can put it somewhere on the page that Arm is a registered trademark etc..

I am not a lawyer :P

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the interest of time and to stay consistent with our backend docs, I'll keep this for now. We can follow up on this later. (I am also not a lawyer so I'd have to do some looking-into-the-matter)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it :)

Building an ExecuTorch Android Demo App <https://github.com/pytorch-labs/executorch-examples/tree/main/dl3/android/DeepLabV3Demo#executorch-android-demo-app>
Building an ExecuTorch iOS Demo App <https://github.com/meta-pytorch/executorch-examples/tree/main/mv3/apple/ExecuTorchDemo>
tutorial-arm.md
tutorial-arm-ethosu.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do see this https://docs- preview.pytorch.org/pytorch/executorch/14299/backends-arm-vgf.html but not under backends, is that intentional?

Copy link
Collaborator Author

@Erik-Lundell Erik-Lundell Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is fixed here? 3acd431

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm , I see what you mean now. I get the same problems with the tutorials, only the VGF tutorial shows up in the sidebar 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it was a typo 🥇 Fingers crossed that this is last adjustment

@@ -0,0 +1,216 @@
Arm&reg; VGF Backend Tutorial
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here about &reg

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/vgf/Vulkan Graph Format/ ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun fact - VGF does not stand for that :)

Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just skimmed, stamping to unblock.
If you want this to get cherry-picked please mention it in 1.0 release tracker.

@Erik-Lundell
Copy link
Collaborator Author

@zingo @Erik-Lundell @agrima1304

There are four pages now...

https://docs.pytorch.org/executorch/main/backends-arm-ethos-u.html https://docs.pytorch.org/executorch/main/backends-arm-vgf.html

and these two tutorial pages

What's the long term plan?

Our plan is that the tutorials essentially are an online version of the minimal_example Jupyter notebooks, for people that don't clone the repo. They are a step-by-step guides on how to do your first lowering. The backend documents all public API and some additional information about the target (Partitioner, Quantizer, CompileSpec, Ethos-U memory modes etc.)

Since the backends are for very separate targets, I don't think it makes sense to mix them, even if the code looks rather similar.

Align with minimal examples with regards to content and code.

Signed-off-by: Erik Lundell <[email protected]>
Change-Id: Iaa2a8abc46483c3f2cd4313212ea58284804fd65
@digantdesai
Copy link
Contributor

digantdesai commented Sep 16, 2025

Yeah I think treating ethos and vgf as completely independent backend from a user reading a doc is the right approach.

And for a given backend, my thinking for backend dev page and a backend [tutorial] page is that, the backend dev page talks about architecture, internals - something like a big picture design which you can't glean easily from reading the code or makes life much easier for someone wants to understand the code base before contributing. For tutorial is more like for a user trying to "try out" the backend without necessarily learning about the internal details.

This is inspired from - image

https://docs.divio.com/documentation-system/

for XNNPACK (not in the best shape today) but
https://docs.pytorch.org/executorch/main/backend-delegates-xnnpack-reference.html - for devs
https://docs.pytorch.org/executorch/main/backends-xnnpack.html and https://docs.pytorch.org/executorch/main/tutorial-xnnpack-delegate-lowering.html - for users

@zingo zingo merged commit d25c35a into pytorch:main Sep 17, 2025
124 of 125 checks passed
@Erik-Lundell
Copy link
Collaborator Author

Yeah I think treating ethos and vgf as completely independent backend from a user reading a doc is the right approach.

And for a given backend, my thinking for backend dev page and a backend [tutorial] page is that, the backend dev page talks about architecture, internals - something like a big picture design which you can't glean easily from reading the code or makes life much easier for someone wants to understand the code base before contributing. For tutorial is more like for a user trying to "try out" the backend without necessarily learning about the internal details.

This is inspired from - image

https://docs.divio.com/documentation-system/

for XNNPACK (not in the best shape today) but https://docs.pytorch.org/executorch/main/backend-delegates-xnnpack-reference.html - for devs https://docs.pytorch.org/executorch/main/backends-xnnpack.html and https://docs.pytorch.org/executorch/main/tutorial-xnnpack-delegate-lowering.html - for users

I really like that classification, thanks!

@zingo
Copy link
Collaborator

zingo commented Sep 17, 2025

@pytorchbot cherry-pick --onto release/1.0 -c docs

pytorchbot pushed a commit that referenced this pull request Sep 17, 2025
Align with minimal examples with regards to content and code.

Signed-off-by: Erik Lundell <[email protected]>
(cherry picked from commit d25c35a)
@pytorchbot
Copy link
Collaborator

Cherry picking #14299

The cherry pick PR is at #14372 The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
Align with minimal examples with regards to content and code.

Signed-off-by: Erik Lundell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants