Revert "Add EXECUTORCH_THREADPOOL_SIZE options, default to u… #14307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing only performance cores (pytorch#14090)" This reverts commit 72d50b2.
GregoryComer
requested review from
kimishpatel,
kirklandsign,
larryliu0820 and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14307
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 66 PendingAs of commit 0ac9b64 with merge base 365cab3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
abhinaykukkadapu
approved these changes
Sep 15, 2025
StrycekSimon
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Sep 23, 2025
…h#14307) …sing only performance cores (pytorch#14090)" This reverts commit 72d50b2. ### Summary Seeing crashes in macos unittest job.
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Oct 7, 2025
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Oct 8, 2025
GregoryComer
added a commit
that referenced
this pull request
Oct 9, 2025
… (#14842) This reverts commit 750cba7. Re-applying the better threadpool size defaults from #14090 with the fix from #14838. This gives a 2-4x speedup for many models and platforms (I measured 4x speedup on M1 with MobileNet V3 + XNNPACK). On high core count server platforms (doing evals, for example), this can give a 100x speedup out of box.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sing only performance cores (#14090)"
This reverts commit 72d50b2.
Summary
Seeing crashes in macos unittest job.