Remove unused broadcast_util include and dep for op__to_dim_order_copy #14323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyprocedure
requested review from
manuelcandales and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14323
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 4a56036 with merge base 5a1c117 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
Author
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
Contributor
|
thanks for continuous improving! will stamp after ci passes! |
Contributor
Author
|
Sounds good! CI passed except for a known flaky trunk test. |
swolchok
approved these changes
Sep 16, 2025
StrycekSimon
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Sep 23, 2025
pytorch#14323) ### Summary `op__to_dim_order_copy` no longer requires `broadcast_util`. In the process of implementing [clone_dim_order](pytorch#12974), the helper function `_to_dim_order_copy_impl` was moved from [op__to_dim_order_copy.cpp](https://github.com/pytorch/executorch/pull/12974/files/06c38ad587c463a360eaed1c2582a9a9dca7bbe6#diff-4f7616dde078e699c95824f2e5446bf4f47ffa53cac140e13ec84cf2065ab294L32) into [copy_ops_util.h](https://github.com/pytorch/executorch/pull/12974/files/06c38ad587c463a360eaed1c2582a9a9dca7bbe6). The only reason `broadcast_util` was needed was to support that helper, so it can now be dropped from `op__to_dim_order_copy`. ### Test plan Enabled `op__to_dim_order_copy_test` in [kernel test CMakeLists.txt](https://github.com/pytorch/executorch/blob/4a4f5a034b6cda395abe7b6aa13b8066b776ffb2/kernels/test/CMakeLists.txt#L289) All tests passed via: `./build-ninja/kernels/test/portable_kernels_test --gtest_filter='OpToDimOrderCopyTest.*'` cc @Gasoonjia
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
op__to_dim_order_copyno longer requiresbroadcast_util.In the process of implementing clone_dim_order, the helper function
_to_dim_order_copy_implwas moved from op__to_dim_order_copy.cpp into copy_ops_util.h. The only reasonbroadcast_utilwas needed was to support that helper, so it can now be dropped fromop__to_dim_order_copy.Test plan
Enabled
op__to_dim_order_copy_testin kernel test CMakeLists.txtAll tests passed via:
./build-ninja/kernels/test/portable_kernels_test --gtest_filter='OpToDimOrderCopyTest.*'cc @Gasoonjia