Skip to content

Android use new llm runner deps #14361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 17, 2025
Merged

Android use new llm runner deps #14361

merged 3 commits into from
Sep 17, 2025
+2 −16

Conversation

kirklandsign
Copy link
Contributor

Summary

Use extension_llm_runner instead of old llama_runner llava_runner

Test plan

CI

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14361

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 47 Pending

As of commit d4608d2 with merge base 75cb986 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 16, 2025
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@kirklandsign kirklandsign marked this pull request as ready for review September 16, 2025 23:56
mergennachin
mergennachin approved these changes Sep 17, 2025
View reviewed changes
Copy link
Contributor

@mergennachin mergennachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this

@mergennachin
Copy link
Contributor

Cherry-pick?

@kirklandsign
Copy link
Contributor Author

Cherry-pick?

Let's CP #14356? This is for sure safe.

Then for this one let me ask Rohan to validate

@kirklandsign
Copy link
Contributor Author

I don't see issues with this PR. We can merge.

@kirklandsign kirklandsign merged commit 02b39bf into main Sep 17, 2025
127 checks passed
@kirklandsign kirklandsign deleted the android-deps-removal branch September 17, 2025 19:38
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
@kirklandsign @StrycekSimon
Android use new llm runner deps (pytorch#14361)
90182b6 
Use extension_llm_runner instead of old llama_runner llava_runner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergennachin mergennachin mergennachin approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@cccclai cccclai Awaiting requested review from cccclai cccclai is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kirklandsign @mergennachin