Update conv replacement pass + tests. #14363
Merged
+210
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14363
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 9c95329 with merge base 44972ad ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
|
@hsharma35 has exported this pull request. If you are a Meta employee, you can view the originating diff in D82577503. |
hsharma35
force-pushed
the
export-D82577503
branch
from
5ba6dab to
4cd2eef
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Sep 17, 2025
Summary: Fix aten->cadence convolution conversion for `wav2letter` torchaudio model. Differential Revision: D82577503
Contributor
|
@hsharma35 has exported this pull request. If you are a Meta employee, you can view the originating diff in D82577503. |
zonglinpeng
approved these changes
Sep 30, 2025
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Sep 30, 2025
Summary: Fix aten->cadence convolution conversion for `wav2letter` torchaudio model. Strides cannot always be set to 1 if output shape is 1. Reviewed By: zonglinpeng Differential Revision: D82577503
DrJessop
approved these changes
Sep 30, 2025
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Sep 30, 2025
Summary: Fix aten->cadence convolution conversion for `wav2letter` torchaudio model. Strides cannot always be set to 1 if output shape is 1. Reviewed By: zonglinpeng, DrJessop Differential Revision: D82577503
hsharma35
force-pushed
the
export-D82577503
branch
from
4cd2eef to
d50e7c5
Compare
Contributor
|
@hsharma35 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D82577503. |
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Sep 30, 2025
Summary: Fix aten->cadence convolution conversion for `wav2letter` torchaudio model. Strides cannot always be set to 1 if output shape is 1. Reviewed By: zonglinpeng, DrJessop Differential Revision: D82577503
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Sep 30, 2025
Summary: Fix aten->cadence convolution conversion for `wav2letter` torchaudio model. Strides cannot always be set to 1 if output shape is 1. Reviewed By: zonglinpeng, DrJessop Differential Revision: D82577503
hsharma35
force-pushed
the
export-D82577503
branch
from
d50e7c5 to
aa5e7ba
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Sep 30, 2025
Summary: Fix aten->cadence convolution conversion for `wav2letter` torchaudio model. Strides cannot always be set to 1 if output shape is 1. Reviewed By: zonglinpeng, DrJessop Differential Revision: D82577503
hsharma35
force-pushed
the
export-D82577503
branch
from
aa5e7ba to
21bb13e
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Sep 30, 2025
Summary: Fix aten->cadence convolution conversion for `wav2letter` torchaudio model. Strides cannot always be set to 1 if output shape is 1. Reviewed By: zonglinpeng, DrJessop Differential Revision: D82577503
Contributor
|
@hsharma35 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D82577503. |
Summary: Pull Request resolved: pytorch#14363 Fix aten->cadence convolution conversion for `wav2letter` torchaudio model. Strides cannot always be set to 1 if output shape is 1. Reviewed By: zonglinpeng, DrJessop Differential Revision: D82577503
Contributor
|
@hsharma35 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D82577503. |
hsharma35
force-pushed
the
export-D82577503
branch
from
21bb13e to
9c95329
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fix aten->cadence convolution conversion for
wav2lettertorchaudio model.Differential Revision: D82577503