Skip to content

Conversation

@winskuo-quic
Copy link
Collaborator

Summary

[PLEASE REMOVE] See CONTRIBUTING.md's Pull Requests for ExecuTorch PR guidelines.

[PLEASE REMOVE] If this PR closes an issue, please add a Fixes #<issue-id> line.

[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: " label. For a list of available release notes labels, check out CONTRIBUTING.md's Pull Requests.

Test plan

[PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 19, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14433

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Cancelled Job, 3 Unrelated Failures

As of commit 93f6d84 with merge base 7ce78c0 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 19, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@winskuo-quic
Copy link
Collaborator Author

Hi @cccclai,
This is the PR to enable LLM Decoder CI, please notice that we are using x86 emulator for QNN execution. Therefore, I am guessing it will take at least 8-10 hours to finish, so I think it will be better to place it under nightly.
This PR is still WIP and I will let you know when it is ready.
Thanks

@winskuo-quic winskuo-quic force-pushed the dev1/winskuo/ga_llm_ci branch 4 times, most recently from d18f688 to 953842a Compare October 14, 2025 07:22
@winskuo-quic winskuo-quic force-pushed the dev1/winskuo/ga_llm_ci branch from 953842a to 43cfbcb Compare October 22, 2025 09:03
@winskuo-quic winskuo-quic marked this pull request as ready for review October 23, 2025 01:26
@winskuo-quic winskuo-quic requested a review from cccclai as a code owner October 23, 2025 01:26
@winskuo-quic
Copy link
Collaborator Author

Hi @cccclai,
This PR is to support community CI to eval PPL scores for static HF decoder models.
I have chosen the smallest HF decoder model for ppl evaluation.
The total time to taken to finish execution is about 5.5 hours.
I would like to confirm on the following:

  1. Is this taking too long and we should move it to nightly.yml.
  2. Is using linux.24xlarge to run CI a concern?

@cccclai
Copy link
Contributor

cccclai commented Oct 23, 2025

Hi @cccclai, This is the PR to enable LLM Decoder CI, please notice that we are using x86 emulator for QNN execution. Therefore, I am guessing it will take at least 8-10 hours to finish, so I think it will be better to place it under nightly. This PR is still WIP and I will let you know when it is ready. Thanks

Thanks for adding CI, this is definately helpful and can help prevent regression early. Yeah nightly will be better, 8-10 hours are quite long. Will need to read which task you're trying.

@winskuo-quic winskuo-quic force-pushed the dev1/winskuo/ga_llm_ci branch from 43cfbcb to 93f6d84 Compare October 27, 2025 01:10
@winskuo-quic
Copy link
Collaborator Author

Thanks for adding CI, this is definately helpful and can help prevent regression early. Yeah nightly will be better, 8-10 hours are quite long. Will need to read which task you're trying.

Sure. The total time actually takes about 5.5 hours to finish, but I have moved it to nightly.yml for now. Could you please help me trigger the nightly.yml test? Thanks

@cccclai
Copy link
Contributor

cccclai commented Oct 27, 2025

Thanks for adding CI, this is definately helpful and can help prevent regression early. Yeah nightly will be better, 8-10 hours are quite long. Will need to read which task you're trying.

Sure. The total time actually takes about 5.5 hours to finish, but I have moved it to nightly.yml for now. Could you please help me trigger the nightly.yml test? Thanks

Yeah just trigger

@winskuo-quic winskuo-quic changed the title Testing CI Qualcomm AI Engine Direct - Testing CI Oct 27, 2025
@winskuo-quic winskuo-quic changed the title Qualcomm AI Engine Direct - Testing CI Qualcomm AI Engine Direct - HF LLM CI Oct 27, 2025
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the CI

@cccclai cccclai merged commit 2c11d56 into pytorch:main Oct 27, 2025
333 of 340 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/nightly CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants