Skip to content

Shift Left: Try building and testing selective_build in OSS #14499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2025
Merged

Shift Left: Try building and testing selective_build in OSS #14499

merged 1 commit into from
Sep 23, 2025

Conversation

@mergennachin
Copy link
Contributor

@mergennachin mergennachin commented Sep 23, 2025 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14499

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 3 Cancelled Jobs, 1 Unrelated Failure

As of commit 42e9adc with merge base 95888a4 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 23, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D83024265.

@mergennachin mergennachin changed the title Try testing in OSS Try testing selective_build in OSS Sep 23, 2025
@mergennachin mergennachin force-pushed the run_buck_test branch 2 times, most recently from fffa9ef to 9ee0494 Compare September 23, 2025 14:39
@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D83024265.

@mergennachin mergennachin force-pushed the run_buck_test branch 2 times, most recently from 1999690 to 39cce76 Compare September 23, 2025 15:32
@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D83024265.

@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D83024265.

@mergennachin mergennachin marked this pull request as ready for review September 23, 2025 15:59
@mergennachin mergennachin changed the title Try testing selective_build in OSS Try building and testing selective_build in OSS Sep 23, 2025
@mergennachin mergennachin changed the title Try building and testing selective_build in OSS Shift Left: Try building and testing selective_build in OSS Sep 23, 2025
@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D83024265.

lucylq
lucylq approved these changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@lucylq lucylq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes 🙏

@mergennachin @facebook-github-bot
Shift Left: Try building and testing selective_build in OSS (#14499)
9c5cede 
Summary:
- Enable buck targets in OSS under codegen/tools/targets.bzl
- Build all buck targets in OSS under codegen/tools/... (Can't test yet due to torch not available in OSS buck)
- Run test_tools_selective_build.py in pytest
- Building on top of #14488

Pull Request resolved: #14499

Reviewed By: lucylq

Differential Revision: D83024265

Pulled By: mergennachin
@facebook-github-bot
Copy link
Contributor

@mergennachin has exported this pull request. If you are a Meta employee, you can view the originating diff in D83024265.

@mergennachin
Copy link
Contributor Author

cc @Erik-Lundell, @zingo Another PR to help test selective_build build jobs

@mergennachin mergennachin mentioned this pull request Sep 23, 2025
Merged
@facebook-github-bot facebook-github-bot merged commit 3d1f591 into main Sep 23, 2025
265 of 270 checks passed
@facebook-github-bot facebook-github-bot deleted the run_buck_test branch September 23, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GregoryComer GregoryComer GregoryComer approved these changes

@lucylq lucylq lucylq approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@swolchok swolchok Awaiting requested review from swolchok

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mergennachin @facebook-github-bot @GregoryComer @lucylq