Skip to content

Conversation

@SaoirseARM
Copy link
Collaborator

@SaoirseARM SaoirseARM commented Sep 23, 2025

Summary

Updates the unit test to use the default run_on_fvp unless explicitly set otherwise.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14504

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 7 Unrelated Failures

As of commit dad4f06 with merge base 25b3d63 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 23, 2025
@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label ciflow/trunk

@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label 'partner: arm'

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Sep 23, 2025
@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label Sep 23, 2025
(test_data,),
aten_op,
exir_ops=[],
run_on_fvp=False,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't these fail for no-fvp jobs without the xfails?

Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this in D83260806.

@digantdesai
Copy link
Contributor

Let me make sure we are not running into some random issue with internal FVP setup with this..

@zingo
Copy link
Collaborator

zingo commented Sep 26, 2025

@digantdesai Thanks, did the internal test work OK ?

@digantdesai
Copy link
Contributor

Slice tests like these test_slice_tensor_u55_INT are failing rest are OK. Let me take a look.

@digantdesai
Copy link
Contributor

We use bundled_io for some internal testing, and seems like None in the test_suite for Slice is causing a problem when creating bundled_io. Still digging..

@digantdesai
Copy link
Contributor

I have a fwd fix. I can land this.. thanks for the patience.

digantdesai pushed a commit to digantdesai/executorch-1 that referenced this pull request Sep 30, 2025
…se (pytorch#14504)

Summary:
Updates the unit test to use the default run_on_fvp unless explicitly set otherwise.

cc digantdesai freddan80 per zingo oscarandersson8218

Pull Request resolved: pytorch#14504

Differential Revision: D83260806

Pulled By: digantdesai
@facebook-github-bot facebook-github-bot merged commit 70bffae into pytorch:main Oct 1, 2025
265 of 279 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants