- 
                Notifications
    
You must be signed in to change notification settings  - Fork 710
 
Arm backend: Use default run_on_fvp=True unless explicitly set to False #14504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm backend: Use default run_on_fvp=True unless explicitly set to False #14504
Conversation
          
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14504
 Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New Failures, 7 Unrelated FailuresAs of commit dad4f06 with merge base 25b3d63 ( NEW FAILURES - The following jobs have failed:
 
 FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
 
 BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures 
 
 This comment was automatically generated by Dr. CI and updates every 15 minutes.  | 
    
| 
           @pytorchbot label ciflow/trunk  | 
    
| 
           @pytorchbot label 'partner: arm'  | 
    
| 
           @pytorchbot label "release notes: none"  | 
    
| (test_data,), | ||
| aten_op, | ||
| exir_ops=[], | ||
| run_on_fvp=False, | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't these fail for no-fvp jobs without the xfails?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
| 
           @digantdesai has imported this pull request. If you are a Meta employee, you can view this in D83260806.  | 
    
| 
           Let me make sure we are not running into some random issue with internal FVP setup with this..  | 
    
| 
           @digantdesai Thanks, did the internal test work OK ?  | 
    
| 
           Slice tests like these   | 
    
| 
           We use bundled_io for some internal testing, and seems like   | 
    
| 
           I have a fwd fix. I can land this.. thanks for the patience.  | 
    
…se (pytorch#14504) Summary: Updates the unit test to use the default run_on_fvp unless explicitly set otherwise. cc digantdesai freddan80 per zingo oscarandersson8218 Pull Request resolved: pytorch#14504 Differential Revision: D83260806 Pulled By: digantdesai
Summary
Updates the unit test to use the default run_on_fvp unless explicitly set otherwise.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218