-
Notifications
You must be signed in to change notification settings - Fork 699
NXP backend: added aten.sub operator support #14514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NXP backend: added aten.sub operator support #14514
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14514
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 2b59bbe with merge base 70ea661 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @novak-vaclav! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
@pytorchbot label "release notes: nxp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mainly added small suggestions and tips (which will be applicable to any of your future ExecuTorch PRs).
Once the changes are implemented, LGTM.
backends/nxp/backend/ir/converter/node_converters/ops_converters/sub_tensor_converter.py
Outdated
Show resolved
Hide resolved
backends/nxp/backend/ir/converter/node_converters/ops_converters/sub_tensor_converter.py
Show resolved
Hide resolved
backends/nxp/tests/ir/converter/node_converter/test_sub_tensor_converter.py
Show resolved
Hide resolved
backends/nxp/tests/ir/converter/node_converter/test_sub_tensor_converter.py
Show resolved
Hide resolved
backends/nxp/tests/ir/converter/node_converter/test_sub_tensor_converter.py
Show resolved
Hide resolved
backends/nxp/tests/ir/converter/node_converter/test_sub_tensor_converter.py
Outdated
Show resolved
Hide resolved
backends/nxp/tests/ir/converter/node_converter/test_sub_tensor_converter.py
Show resolved
Hide resolved
backends/nxp/tests/ir/converter/node_converter/test_sub_tensor_converter.py
Outdated
Show resolved
Hide resolved
backends/nxp/tests/ir/converter/node_converter/test_sub_tensor_converter.py
Outdated
Show resolved
Hide resolved
backends/nxp/tests/ir/converter/node_converter/test_sub_tensor_converter.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Once the tests pass, we can merge,
d8106c7 to
8ce0efd
Compare
155b283 to
2b59bbe
Compare
Summary
adds support for aten.sub operator
Test plan
tests can be manually run using
pytest -c /dev/null backends/nxp/tests/