Skip to content

Conversation

@novak-vaclav
Copy link
Contributor

@novak-vaclav novak-vaclav commented Sep 23, 2025

Summary

adds support for aten.sub operator

Test plan

tests can be manually run using pytest -c /dev/null backends/nxp/tests/

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14514

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 2b59bbe with merge base 70ea661 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla
Copy link

meta-cla bot commented Sep 23, 2025

Hi @novak-vaclav!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@novak-vaclav novak-vaclav marked this pull request as draft September 23, 2025 14:52
@novak-vaclav novak-vaclav marked this pull request as ready for review September 23, 2025 14:56
@novak-vaclav novak-vaclav marked this pull request as draft September 23, 2025 14:56
@novak-vaclav novak-vaclav marked this pull request as ready for review September 23, 2025 15:18
@novak-vaclav novak-vaclav marked this pull request as draft September 23, 2025 15:21
@novak-vaclav
Copy link
Contributor Author

@pytorchbot label "release notes: nxp"

@pytorch-bot pytorch-bot bot added the release notes: nxp Changes to the NXP Neutron backend delegate label Sep 23, 2025
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 23, 2025
Copy link
Collaborator

@MartinPavella MartinPavella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mainly added small suggestions and tips (which will be applicable to any of your future ExecuTorch PRs).
Once the changes are implemented, LGTM.

@novak-vaclav novak-vaclav marked this pull request as ready for review September 24, 2025 08:20
Copy link
Collaborator

@MartinPavella MartinPavella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once the tests pass, we can merge,

@MartinPavella MartinPavella force-pushed the feature/EIEX-538-add-aten-sub-operator branch from d8106c7 to 8ce0efd Compare October 2, 2025 05:48
@MartinPavella MartinPavella force-pushed the feature/EIEX-538-add-aten-sub-operator branch from 155b283 to 2b59bbe Compare October 3, 2025 06:46
@MartinPavella MartinPavella merged commit 05799c9 into pytorch:main Oct 3, 2025
128 of 130 checks passed
@MartinPavella MartinPavella deleted the feature/EIEX-538-add-aten-sub-operator branch October 3, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: nxp Changes to the NXP Neutron backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants