NXP backend: Fix mean.dim delegation and tests.
#14581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14581
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 9 Pending, 2 Unrelated FailuresAs of commit e24bbcf with merge base 9c7cb61 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
MartinPavella
force-pushed
the
upstream/main-nxp/EIEX-522-fix-mean.dim-delegation-and-tests
branch
from
c5280bb to
0222b03
Compare
Collaborator
Author
|
@pytorchbot label "module: nxp" "release notes: nxp" |
pytorch-bot
bot
added
module: nxp
roman-janik-nxp
requested changes
Nov 6, 2025
backends/nxp/backend/ir/converter/node_converters/ops_converters/mean_dim_converter.py
Outdated
Show resolved
Hide resolved
robert-kalmar
approved these changes
Nov 7, 2025
Collaborator
robert-kalmar
left a comment
robert-kalmar
left a comment
There was a problem hiding this comment.
LGTM, just please fix the hardcoded num_macs as Roman suggests.
MartinPavella
force-pushed
the
upstream/main-nxp/EIEX-522-fix-mean.dim-delegation-and-tests
branch
from
0222b03 to
06d4582
Compare
roman-janik-nxp
approved these changes
Nov 7, 2025
MartinPavella
force-pushed
the
upstream/main-nxp/EIEX-522-fix-mean.dim-delegation-and-tests
branch
from
06d4582 to
e24bbcf
Compare
robert-kalmar
deleted the
upstream/main-nxp/EIEX-522-fix-mean.dim-delegation-and-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the delegation condition for the
aten,mean,dimoperator to better reflect the requirements of Neutron.Test plan
Unit tests provided.
cc @robert-kalmar @JakeStevens @digantdesai