Skip to content

Conversation

@tmi
Copy link
Contributor

@tmi tmi commented Sep 25, 2025

Gets rid of the 'deprecated' warnings that pop up multiple times during build/install

Bumps setuptools requirement to accept the new license declaration format

Summary

Just a tiny PR, no change to API or code or anything. The license itself is as before, it just changes the manner in which it is declared -- as recommended by the PyPA guidelines https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license

I tried to find any issue related to this but found none. And I guess not worth it creating one

Test plan

Since this does not change any of the code, I just tested that the package can be installed/built as before via ./install_executorch.sh, and that the deprecation warnings vanish

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14592

Note: Links to docs will display an error until the docs builds have been completed.

❌ 14 New Failures

As of commit add7142 with merge base db8d04f (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla
Copy link

meta-cla bot commented Sep 25, 2025

Hi @tmi!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@tmi
Copy link
Contributor Author

tmi commented Sep 25, 2025

@pytorchbot label "topic: not user facing"

@meta-cla
Copy link

meta-cla bot commented Sep 25, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 25, 2025
@mergennachin
Copy link
Contributor

Why did you upgrade setuptools?

@tmi
Copy link
Contributor Author

tmi commented Sep 26, 2025

@mergennachin without the lower bound, the license fields fail to be parsed -- the first CI run failed because of that (as the runner defaulted to a cached version, 60-smth). I just grabbed the bound from a similar issue vllm-project/vllm#17389. I can leave a comment in the pyproject.toml linking the PEP that requries this bound. Thinking of it, we may also want to add an upper bound

The failures of the recent runs, like cannot import name 'PerBlock' from 'torchao.quantization.pt2e' or ValueError: QNN backend is not available. are not related, right? Or is it possible that the setuptools bump caused some silent failure of a prerequisite build?

@mergennachin
Copy link
Contributor

Okay got it

That seems to be the right version.

The other failures seem unrelated.

Please also update https://github.com/pytorch/executorch/blob/main/requirements-dev.txt

@mergennachin
Copy link
Contributor

Test failures for "Test CUDA Builds" look legit

Can you also update packaging>=24.2 in here?

"packaging",

Gets rid of the 'deprecated' warnings that pop up multiple
times during build/install

Bumps setuptools, packaging requirements to accept the new format
@tmi tmi force-pushed the fix-pyproject-license branch from a993c85 to add7142 Compare October 2, 2025 07:09
@tmi
Copy link
Contributor Author

tmi commented Oct 2, 2025

Test failures for "Test CUDA Builds" look legit. Can you also update packaging>=24.2 in here?

right, thx. I updated it, but in the build-system's requirements, not in the depedendencies -- I think thats more suitable place, given the test failure. Not sure if the runtime packaging dependency needs a lower bound too since there is no runtime setuptools dependency -- I'd guess not

@mergennachin mergennachin added ciflow/trunk ciflow/binaries ciflow/binaries/all Release PRs with this label will build wheels for all python versions labels Oct 2, 2025
@mergennachin mergennachin merged commit a1652f9 into pytorch:main Oct 2, 2025
530 of 579 checks passed
@mergennachin
Copy link
Contributor

Thank you @tmi

@mergennachin
Copy link
Contributor

@pytorchbot cherry-pick --onto release/1.0 -c release --fixes "upgrades setuptools and packaging to improve logs during installation/build"

pytorchbot pushed a commit that referenced this pull request Oct 2, 2025
Gets rid of the 'deprecated' warnings that pop up multiple times during
build/install

Bumps setuptools requirement to accept the new license declaration
format

### Summary
Just a tiny PR, no change to API or code or anything. The license itself
is as before, it just changes the manner in which it is declared -- as
recommended by the PyPA guidelines
https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license

I tried to find any issue related to this but found none. And I guess
not worth it creating one

### Test plan
Since this does not change any of the code, I just tested that the
package can be installed/built as before via `./install_executorch.sh`,
and that the deprecation warnings vanish

(cherry picked from commit a1652f9)
@pytorchbot
Copy link
Collaborator

Cherry picking #14592

The cherry pick PR is at #14761 and it is linked with issue upgrades setuptools and packaging to improve logs during installation/build. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries/all Release PRs with this label will build wheels for all python versions ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants