- 
                Notifications
    You must be signed in to change notification settings 
- Fork 706
Fix pyproject.toml license classifier deprecation #14592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14592
 Note: Links to docs will display an error until the docs builds have been completed. ❌ 14 New FailuresAs of commit add7142 with merge base db8d04f ( NEW FAILURES - The following jobs have failed:
 
 This comment was automatically generated by Dr. CI and updates every 15 minutes. | 
| Hi @tmi! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with  If you have received this in error or have any questions, please contact us at [email protected]. Thanks! | 
| This PR needs a  | 
| @pytorchbot label "topic: not user facing" | 
| Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! | 
9a15e25    to
    8cc6c38      
    Compare
  
    8cc6c38    to
    cac42f6      
    Compare
  
    | Why did you upgrade setuptools? | 
| @mergennachin without the lower bound, the  The failures of the recent runs, like  | 
| Okay got it That seems to be the right version. The other failures seem unrelated. Please also update https://github.com/pytorch/executorch/blob/main/requirements-dev.txt | 
cac42f6    to
    a993c85      
    Compare
  
    | Test failures for "Test CUDA Builds" look legit Can you also update packaging>=24.2 in here? Line 61 in 7ed9266 
 | 
Gets rid of the 'deprecated' warnings that pop up multiple times during build/install Bumps setuptools, packaging requirements to accept the new format
a993c85    to
    add7142      
    Compare
  
    | 
 right, thx. I updated it, but in the  | 
| Thank you @tmi | 
| @pytorchbot cherry-pick --onto release/1.0 -c release --fixes "upgrades setuptools and packaging to improve logs during installation/build" | 
Gets rid of the 'deprecated' warnings that pop up multiple times during build/install Bumps setuptools requirement to accept the new license declaration format ### Summary Just a tiny PR, no change to API or code or anything. The license itself is as before, it just changes the manner in which it is declared -- as recommended by the PyPA guidelines https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license I tried to find any issue related to this but found none. And I guess not worth it creating one ### Test plan Since this does not change any of the code, I just tested that the package can be installed/built as before via `./install_executorch.sh`, and that the deprecation warnings vanish (cherry picked from commit a1652f9)
| Cherry picking #14592The cherry pick PR is at #14761 and it is linked with issue upgrades setuptools and packaging to improve logs during installation/build. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job | 
Gets rid of the 'deprecated' warnings that pop up multiple times during build/install
Bumps setuptools requirement to accept the new license declaration format
Summary
Just a tiny PR, no change to API or code or anything. The license itself is as before, it just changes the manner in which it is declared -- as recommended by the PyPA guidelines https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license
I tried to find any issue related to this but found none. And I guess not worth it creating one
Test plan
Since this does not change any of the code, I just tested that the package can be installed/built as before via
./install_executorch.sh, and that the deprecation warnings vanish