Skip to content

Support uploading different AAR to S3 #14605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 25, 2025
Merged

Support uploading different AAR to S3 #14605

merged 2 commits into from
Sep 25, 2025

Conversation

kirklandsign
Copy link
Contributor

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14605

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 25, 2025
@kirklandsign kirklandsign marked this pull request as ready for review September 25, 2025 18:51
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@kirklandsign kirklandsign merged commit 79e9224 into main Sep 25, 2025
126 of 134 checks passed
@kirklandsign kirklandsign deleted the flavor-url branch September 25, 2025 18:57
@kirklandsign
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/1.0 -c release

pytorchbot pushed a commit that referenced this pull request Sep 25, 2025
@kirklandsign @pytorchbot
Support uploading different AAR to S3 (#14605)
3eeff48 
Now stage AAR upload to
https://ossci-android.s3.amazonaws.com/executorch/release/${VERSION}-${FLAVOR}/executorch.aar

so we can have multiple flavors.

Example: https://github.com/pytorch/executorch/actions/runs/18017149226,
https://github.com/pytorch/executorch/actions/runs/18017146445
(cherry picked from commit 79e9224)
@pytorchbot
Copy link
Collaborator

Cherry picking #14605

The cherry pick PR is at #14606 The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Sep 25, 2025
Open
kirklandsign added a commit that referenced this pull request Sep 25, 2025
@kirklandsign
Support uploading different AAR to S3 (#14605)
2e77313 
Now stage AAR upload to
https://ossci-android.s3.amazonaws.com/executorch/release/${VERSION}-${FLAVOR}/executorch.aar

so we can have multiple flavors.

Example: https://github.com/pytorch/executorch/actions/runs/18017149226,
https://github.com/pytorch/executorch/actions/runs/18017146445
GregoryComer pushed a commit that referenced this pull request Sep 26, 2025
@kirklandsign @GregoryComer
Support uploading different AAR to S3 (#14605)
ea07fc2 
Now stage AAR upload to
https://ossci-android.s3.amazonaws.com/executorch/release/${VERSION}-${FLAVOR}/executorch.aar

so we can have multiple flavors.

Example: https://github.com/pytorch/executorch/actions/runs/18017149226,
https://github.com/pytorch/executorch/actions/runs/18017146445
(cherry picked from commit 79e9224)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shoumikhin shoumikhin shoumikhin approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kirklandsign @pytorchbot @shoumikhin