Skip to content

Conversation

@MartinPavella
Copy link
Collaborator

Summary

Fix failing separable convolution test.

The error is larger on the CI than on my PC.

Fixes #14709

Test plan

N/A

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 1, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14719

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Cancelled Jobs

As of commit 339d879 with merge base e0dda90 (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 1, 2025
@github-actions
Copy link

github-actions bot commented Oct 1, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@MartinPavella MartinPavella changed the base branch from main to release/1.0 October 1, 2025 09:59
@MartinPavella MartinPavella force-pushed the bugfix/fix-nxp-separable-conv-test branch 6 times, most recently from 4c5bfa7 to 018acbd Compare October 2, 2025 13:23
@MartinPavella MartinPavella marked this pull request as ready for review October 3, 2025 06:47
@MartinPavella MartinPavella force-pushed the bugfix/fix-nxp-separable-conv-test branch from 018acbd to 339d879 Compare October 3, 2025 09:00
@robert-kalmar
Copy link
Collaborator

@GregoryComer , @digantdesai , the fix is in place. How we shall proceed? The branch is protected (make sense). Will you arrange the merging? Or we shall go through the main branch (even thought the test is not failing there)

@mergennachin mergennachin merged commit 5e65da8 into pytorch:release/1.0 Oct 3, 2025
120 of 122 checks passed
@mergennachin
Copy link
Contributor

Thanks @robert-kalmar @MartinPavella just merged into our release branch

Cc @GregoryComer

@mergennachin mergennachin changed the title Bugfix/fix nxp separable conv test [Release Only] Bugfix/fix nxp separable conv test Oct 3, 2025
@GregoryComer
Copy link
Member

@pytorchbot cherry-pick --onto main -c fixnewfeature

pytorchbot pushed a commit that referenced this pull request Oct 3, 2025
### Summary
Fix failing separable convolution test.

The error is larger on the CI than on my PC.

Fixes #14709

### Test plan
N/A

(cherry picked from commit 5e65da8)
@pytorchbot
Copy link
Collaborator

Cherry picking #14719

The cherry pick PR is at #14800 and it is recommended to link a fixnewfeature cherry pick PR with an issue.

Details for Dev Infra team Raised by workflow job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NXP test_split_group_convolution__2d_1_group_3 failing on release branch CI

5 participants