Skip to content

refactor:(samsung backend): replace pkg_resources with importlib.resources for schema loading #14726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2025
Merged

refactor:(samsung backend): replace pkg_resources with importlib.resources for schema loading #14726

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions backends/samsung/serialization/compile_options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
from dataclasses import dataclass
from enum import IntEnum, unique

import pkg_resources
from importlib.resources import files

from executorch.exir._serialize._dataclass import _DataclassEncoder
from executorch.exir._serialize._flatbuffer import _flatc_compile
from executorch.exir.backend.backend_details import CompileSpec
Expand All @@ -36,12 +37,15 @@ def gen_samsung_backend_compile_spec_core(options: EnnExecuTorchOptions) -> Comp
with tempfile.TemporaryDirectory() as d:
# schema
schema_path = os.path.join(d, "{}.fbs".format(COMPILE_OPTION_SCHEMA_NAME))

schema_content = (
files(__package__)
.joinpath(f"{COMPILE_OPTION_SCHEMA_NAME}.fbs")
.read_bytes()
)

with open(schema_path, "wb") as schema_file:
schema_file.write(
pkg_resources.resource_string(
__name__, "{}.fbs".format(COMPILE_OPTION_SCHEMA_NAME)
)
)
schema_file.write(schema_content)
# dump json
json_path = os.path.join(d, "{}.json".format(COMPILE_OPTION_SCHEMA_NAME))
enn_options_json = json.dumps(options, cls=_DataclassEncoder, indent=4)
Expand Down
Loading