Skip to content

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Oct 2, 2025

Run

python export_quant_xnnpack.py 

Notice that there are no external weights saved. When commenting out 'quantize_', we see weights saved externally.
This is because xnnpack fuses(?) the quantization nodes, and the original tag disappears.

I can also set a breakpoint in node_visitor.py and manually tag torchao_dequantize_affine_default. So I think we need some way to tag nodes post-to_edge_transform_and_lower.

Copy link

pytorch-bot bot commented Oct 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14736

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 12 New Failures, 41 Cancelled Jobs

As of commit 9918d60 with merge base 270873f (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 2, 2025
Copy link

github-actions bot commented Oct 2, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@lucylq lucylq force-pushed the lfq.xnnpack-quant-sep branch 4 times, most recently from 78c39d9 to 55cf673 Compare October 3, 2025 21:16
@lucylq lucylq force-pushed the lfq.xnnpack-quant-sep branch from 55cf673 to 9918d60 Compare October 7, 2025 18:25
@lucylq lucylq closed this Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant