Summary: Use javaClassStatic() for class references stored in static …

[psiddh]

…variables - creates global references safe for persistence

findClassLocal() returns a local reference. Storing it in static auto exceptionClass = ... could result in potential 'invalid local reference:' as local references become invalid when the JNI frame ends

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Summary

[PLEASE REMOVE] See CONTRIBUTING.md's Pull Requests for ExecuTorch PR guidelines.

[PLEASE REMOVE] If this PR closes an issue, please add a Fixes #<issue-id> line.

[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: " label. For a list of available release notes labels, check out CONTRIBUTING.md's Pull Requests.

Test plan

[PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14744

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit e6f4a47 with merge base f24351a ():

NEW FAILURE - The following job has failed:

• pull / test-samsung-models-linux / linux-job (gh)
  RuntimeError: Command docker exec -t 111c3b4d3d33927d528c30a7646b88a399467d30e82c38be689b19de3b0fbf39 /exec failed with exit code 1

FLAKY - The following job failed but was likely due to flakiness present on trunk:

• pull / unittest-arm-backend-with-no-fvp (test_pytest_models) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

• pull / unittest / macos / macos-job (gh) (trunk failure)
  export/tests/test_target_recipes.py::TestTargetRecipes::test_linear_model

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[github-actions]

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

[mergennachin]

What are your thoughts on moving this definition to the jni_helper.h file

[mergennachin]

  auto env = facebook::jni::Environment::current();
  if (!env) {
    // Handle case where JNI environment is not available
    return;
  }

[psiddh]

Doesn't hurt to add defensive check (although checking for null is not very typical I think), but handling cases where it is null can be tricky, We can't talk to java layer as jni env is not valid, and it is not ideal to throw c++ exception from here.

[mergennachin]

Also, any thoughts on catching C++ exceptions? Something like this:

  try {
    static const auto exceptionClass = JExecutorchRuntimeException::javaClassStatic();
    // ... rest of the code
  } catch (const std::exception& e) {
    // Log the error or handle gracefully
    // Avoid throwing C++ exceptions across JNI boundary
  }

[psiddh]

I think catching C++ exceptions inside a helper like this can mask real initialization bugs and make debugging harder.

[psiddh]

@pytorchbot cherry-pick --onto release/1.0 -c critical

[pytorchbot]

Cherry picking #14744

The cherry pick PR is at #14811 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

• [v1.0.0] Release Tracker #14288 (comment)

Details for Dev Infra team

Raised by workflow job