Skip to content

Conversation

agrima1304
Copy link
Collaborator

@agrima1304 agrima1304 commented Oct 2, 2025

These ops are not in the list of core ATen ops and are decomposed automatically when lowering the graph (https://docs.pytorch.org/docs/main/export.html#export-ir-decompositions), so only the tests need to be added.

All three of these ops are in this decomp table: https://github.com/pytorch/pytorch/blob/5d749ceb92c2c28bcfbdf918b4ab99b1a91fcb50/torch/_decomp/__init__.py#L295

Also adds a small comment in the sub op tests.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Copy link

pytorch-bot bot commented Oct 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14747

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 9e43284 with merge base 45336ce (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 2, 2025
@agrima1304 agrima1304 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Oct 2, 2025
@agrima1304 agrima1304 force-pushed the op-tests branch 4 times, most recently from f4c6d8c to 2cd1d41 Compare October 9, 2025 08:56
Signed-off-by: Agrima Khare <[email protected]>
Change-Id: I8aea84b9a83bbe1b429eeb474676854f41e09ee3
@Sebastian-Larsson
Copy link
Collaborator

Unrelated CI errors.

@Sebastian-Larsson Sebastian-Larsson merged commit 519c7ff into pytorch:main Oct 15, 2025
288 of 290 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants