Add null pointer check for evalues #14749
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeStevens
requested review from
JacobSzwejbka,
lucylq and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14749
Note: Links to docs will display an error until the docs builds have been completed. ❌ 9 New FailuresAs of commit 66e11e2 with merge base 7116e0a ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83742246. |
JacobSzwejbka
requested changes
Oct 2, 2025
| executorch::aten::ArrayRef<double> toDoubleList() const { | ||
| ET_CHECK_MSG(isDoubleList(), "EValue is not a Double List."); | ||
| ET_CHECK_MSG( | ||
| payload.copyable_union.as_double_list_ptr != nullptr, |
There was a problem hiding this comment.
We should check this in the ctors no?
There was a problem hiding this comment.
Kept the original checks and added in boxed ctor and each evalue ctor
JakeStevens
force-pushed
the
export-D83742246
branch
from
6c3f352 to
25522f9
Compare
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Oct 3, 2025
Summary: The to* functions could de-reference a NULL pointer. Adding a check. Differential Revision: D83742246
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Oct 3, 2025
Summary: The to* functions could de-reference a NULL pointer. Adding a check. Differential Revision: D83742246
JakeStevens
force-pushed
the
export-D83742246
branch
from
25522f9 to
a6d92e4
Compare
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Oct 3, 2025
Summary: The to* functions could de-reference a NULL pointer. Adding a check. Differential Revision: D83742246
JakeStevens
force-pushed
the
export-D83742246
branch
from
a6d92e4 to
b5816ae
Compare
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Oct 3, 2025
Summary: The to* functions could de-reference a NULL pointer. Adding a check. Differential Revision: D83742246
JakeStevens
force-pushed
the
export-D83742246
branch
from
b5816ae to
302782a
Compare
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
Summary: The to* functions could de-reference a NULL pointer. Adding a check. Differential Revision: D83742246
JakeStevens
force-pushed
the
export-D83742246
branch
from
302782a to
66e11e2
Compare
mergennachin
approved these changes
Oct 3, 2025
JacobSzwejbka
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The to* functions could de-reference a NULL pointer. Adding a check.
Differential Revision: D83742246