Skip to content

Conversation

@JacobSzwejbka
Copy link
Contributor

Summary: meta-pytorch/tokenizers@65e41a9 bringing in this change for windows builds of voxtral runner

Differential Revision: D83759380

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14751

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 1353f4f with merge base 4372a14 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 2, 2025
@facebook-github-bot
Copy link
Contributor

@JacobSzwejbka has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83759380.

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@mergennachin
Copy link
Contributor

Make sure to cherry-pick

Summary:
Pull Request resolved: pytorch#14751

meta-pytorch/tokenizers@65e41a9 bringing in this change for windows builds of voxtral runner

Differential Revision: D83759380
@JacobSzwejbka
Copy link
Contributor Author

Make sure to cherry-pick

Are we putting the windows desktop changes in 1.0?

@JacobSzwejbka JacobSzwejbka merged commit 19258d2 into pytorch:main Oct 2, 2025
130 of 132 checks passed
@JacobSzwejbka JacobSzwejbka deleted the export-D83759380 branch October 2, 2025 19:47
@JacobSzwejbka
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/1.0 -c fixnewfeature

@pytorchbot
Copy link
Collaborator

Cherry picking #14751

Command git -C /home/runner/work/executorch/executorch cherry-pick -x -X theirs 19258d284c8257a53471a63d0b92f462f8eb2a5c returned non-zero exit code 1

hint: Recursive merging with submodules currently only supports trivial cases.
hint: Please manually handle the merging of each conflicted submodule.
hint: This can be accomplished with the following steps:
hint:  - go to submodule (extension/llm/tokenizers), and either merge commit 65e41a9
hint:    or update to an existing commit which has merged those changes
hint:  - come back to superproject and run:
hint:
hint:       git add extension/llm/tokenizers
hint:
hint:    to record the above merge or update
hint:  - resolve any other conflicts in the superproject
hint:  - commit the resulting index in the superproject
hint:
hint: Disable this message with "git config set advice.submoduleMergeConflict false"
Failed to merge submodule extension/llm/tokenizers (commits don't follow merge-base)
CONFLICT (submodule): Merge conflict in extension/llm/tokenizers
error: could not apply 19258d284c... update tokenizer pin (#14751)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Details for Dev Infra team Raised by workflow job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants