Skip to content

Fixed assumption on out_shift for quantized linear #14789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fixed assumption on out_shift for quantized linear #14789

wants to merge 6 commits into from

Conversation

DrJessop
Copy link
Contributor

@DrJessop DrJessop commented Oct 3, 2025

Summary: out shift should be int32

Differential Revision: D83875670

Andrew Grebenisan added 6 commits October 3, 2025 14:48
@facebook-github-bot
Add transposed im2row (pytorch#14738)
a5f3055 
Summary:

Continued support for custom cadence ops.

Reviewed By: hsharma35, eigen-k

Differential Revision: D83709868
@facebook-github-bot
Fix op signature for avg_pool2d (pytorch#14787)
8151ce2 
Summary:

The default for padding was incorrect, adding default with the correct dtype

Differential Revision: D83873533
@facebook-github-bot
Replace quantized conv and relu non-tensor variants with per tensor v…
1e4a8c3 
…ariants

Summary: Fix to just call the per tensor variants for quantized conv and quantized relu, since those are the only ones we are supporting.

Differential Revision: D83873738
@facebook-github-bot
Fix avg_pool2d replace ops pass
705fccc 
Summary: The original pass didn't fetch the user-provided zero point if it existed, it just assumed a hard-coded zero point. Fixed now.

Differential Revision: D83873937
@facebook-github-bot
Removed support for non-per-tensor quantized relu (pytorch#14788)
f783d97 
Summary:

Not supporting quantized relu default, so removing it from ref_implementations

Differential Revision: D83874866
@facebook-github-bot
Fixed assumption on out_shift for quantized linear
f472850 
Summary: out shift should be int32

Differential Revision: D83875670
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14789

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 6 Cancelled Jobs

As of commit f472850 with merge base b021fd0 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 3, 2025
@facebook-github-bot
Copy link
Contributor

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83875670.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83875670.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrJessop @facebook-github-bot