Arm backend: Fix Mypy error related to _QuantProperty.qspec #14814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, _QuantProperty.qspec had the type hint `type[QuantizationSpecBase] | List[type[QuantizationSpecBase]]`, which implies that _QuantProperty.qspec should be a class object. However, in torchao the class `QuantizationAnnotation` has this property: `output_qspec: Optional[QuantizationSpecBase] = None` which is set to _QuantProperty.qspec through a series of function calls. `output_qspec` should, as the type hinting implies, be an instance of a class of `QuantizationSpecBase`, not a class object. Therefore, change `type[QuantizationSpecBase] | List[type[QuantizationSpecBase]]` to `QuantizationSpecBase | List[QuantizationSpecBase]`. This allows us to remove a bunch of mypy ignores. Change-Id: Idbb5ca4ba9ab17e8805b1e4d647e46e86f434b69 Signed-off-by: Sebastian Larsson <[email protected]>
Sebastian-Larsson
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14814
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 2 Unrelated FailuresAs of commit b4d664e with merge base 3b16bc1 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
Unrelated CI failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, _QuantProperty.qspec had the type hint
type[QuantizationSpecBase] | List[type[QuantizationSpecBase]], which implies that _QuantProperty.qspec should be a class object. However, in torchao the classQuantizationAnnotationhas this property:output_qspec: Optional[QuantizationSpecBase] = Nonewhich is set to _QuantProperty.qspec through a series of function calls.
output_qspecshould, as the type hinting implies, be an instance of a class ofQuantizationSpecBase, not a class object.Therefore, change
type[QuantizationSpecBase] | List[type[QuantizationSpecBase]]toQuantizationSpecBase | List[QuantizationSpecBase]. This allows us to remove a bunch of mypy ignores.cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai